From 55164f901b04a0c06a9d63a582525a115984fb42 Mon Sep 17 00:00:00 2001 From: David Majnemer Date: Sun, 11 Jan 2015 09:57:13 +0000 Subject: [PATCH] Basic: [asmSymbolicName] follows the same rule as numbers in asm inputs Input constraints like "0" and "[foo]" should be treated the same when it comes to their corresponding output constraint. This fixes PR21850. llvm-svn: 225605 --- clang/lib/Basic/TargetInfo.cpp | 4 ++++ clang/test/Sema/asm.c | 7 +++++++ 2 files changed, 11 insertions(+) diff --git a/clang/lib/Basic/TargetInfo.cpp b/clang/lib/Basic/TargetInfo.cpp index 15b8c83..535c87e 100644 --- a/clang/lib/Basic/TargetInfo.cpp +++ b/clang/lib/Basic/TargetInfo.cpp @@ -583,6 +583,10 @@ bool TargetInfo::validateInputConstraint(ConstraintInfo *OutputConstraints, if (Info.hasTiedOperand() && Info.getTiedOperand() != Index) return false; + // A number must refer to an output only operand. + if (OutputConstraints[Index].isReadWrite()) + return false; + Info.setTiedOperand(Index, OutputConstraints[Index]); break; } diff --git a/clang/test/Sema/asm.c b/clang/test/Sema/asm.c index 10d845e..f386f52 100644 --- a/clang/test/Sema/asm.c +++ b/clang/test/Sema/asm.c @@ -190,3 +190,10 @@ void fn4() { : "=r"(l) : "#m"(l)); // expected-error {{invalid input constraint '#m' in asm}} } + +void fn5() { + int l; + __asm__("" + : [g] "+r"(l) + : "[g]"(l)); // expected-error {{invalid input constraint '[g]' in asm}} +} -- 2.7.4