From 54dab738de58291ebefc8ff0569a799efaff5d82 Mon Sep 17 00:00:00 2001 From: Ankit Jain Date: Wed, 7 Jun 2023 11:37:38 -0400 Subject: [PATCH] [wasm] Add workaround `NuGet-Migrations` issue for a missed case (#87041) One case was missed in the earlier attempt at this, which caused some of the tests in wasm runtime tests to not get the workaround script. One such example - `JIT.PGO` The other cases had: ```sh export WasmTestAppArgs="$WasmTestAppArgs --exclusion-list=TestExclusionList.txt" chmod +x ./RunTests.sh (CONSOLE_TEMP_DIR="$(mktemp -d)" ; "$DOTNET_ROOT/dotnet" new console -o "$CONSOLE_TEMP_DIR" ; rm -rf "$CONSOLE_TEMP_DIR") || true ./RunTests.sh ``` .. and the broken one has: ```sh dotnet $CORE_ROOT/xunit/xunit.console.dll profiler/unittest/profiler.unittest.XUnitWrapper.dll -parallel collections -nocolor -noshadow -xml testResults.xml -trait TestGroup=profiler.unittest ``` .. no workaround with `dotnet new ..`. --- src/tests/Common/helixpublishwitharcade.proj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tests/Common/helixpublishwitharcade.proj b/src/tests/Common/helixpublishwitharcade.proj index 13f4894..b0ff275 100644 --- a/src/tests/Common/helixpublishwitharcade.proj +++ b/src/tests/Common/helixpublishwitharcade.proj @@ -907,7 +907,7 @@ %(PayloadDirectory) $(_WorkaroundForNuGetMigrationsForPrepending) dotnet $(XUnitRunnerDll) %(XUnitWrapperDlls) $(XUnitRunnerArgs) - dotnet $(XUnitRunnerDll) %(XUnitWrapperDlls) $(XUnitRunnerArgs) -trait TestGroup=%(TestGroup) + $(_WorkaroundForNuGetMigrationsForPrepending) dotnet $(XUnitRunnerDll) %(XUnitWrapperDlls) $(XUnitRunnerArgs) -trait TestGroup=%(TestGroup) $([System.TimeSpan]::FromMinutes($(TimeoutPerTestCollectionInMinutes))) coreclr_tests.run.$(TargetOS).$(TargetArchitecture).$(Configuration).mch;coreclr_tests.run.$(TargetOS).$(TargetArchitecture).$(Configuration).log -- 2.7.4