From 54b2914accb4f5c9b58305fd6da405d20a47c452 Mon Sep 17 00:00:00 2001 From: Simon Pilgrim Date: Sun, 12 Jan 2020 22:08:56 +0000 Subject: [PATCH] Fix "pointer is null" static analyzer warnings. NFCI. Use castAs<> instead of getAs<> since the pointers are dereferenced immediately and castAs will perform the null assertion for us. --- clang/lib/AST/VTableBuilder.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/clang/lib/AST/VTableBuilder.cpp b/clang/lib/AST/VTableBuilder.cpp index 5688042..2b5b74b 100644 --- a/clang/lib/AST/VTableBuilder.cpp +++ b/clang/lib/AST/VTableBuilder.cpp @@ -270,8 +270,8 @@ static BaseOffset ComputeReturnAdjustmentBaseOffset(ASTContext &Context, const CXXMethodDecl *DerivedMD, const CXXMethodDecl *BaseMD) { - const FunctionType *BaseFT = BaseMD->getType()->getAs(); - const FunctionType *DerivedFT = DerivedMD->getType()->getAs(); + const auto *BaseFT = BaseMD->getType()->castAs(); + const auto *DerivedFT = DerivedMD->getType()->castAs(); // Canonicalize the return types. CanQualType CanDerivedReturnType = -- 2.7.4