From 54904aba474723d6cdfff4d34401863bfcb68d8b Mon Sep 17 00:00:00 2001 From: David Bolvansky Date: Tue, 3 Sep 2019 10:54:25 +0000 Subject: [PATCH] Fixit for -Wfinal-dtor-non-final-class llvm-svn: 370740 --- clang/lib/Sema/SemaDeclCXX.cpp | 1 - clang/test/SemaCXX/warn-final-dtor-non-final-class.cpp | 1 - 2 files changed, 2 deletions(-) diff --git a/clang/lib/Sema/SemaDeclCXX.cpp b/clang/lib/Sema/SemaDeclCXX.cpp index e2f0aef..f5ec46f 100644 --- a/clang/lib/Sema/SemaDeclCXX.cpp +++ b/clang/lib/Sema/SemaDeclCXX.cpp @@ -6242,7 +6242,6 @@ void Sema::CheckCompletedCXXClass(CXXRecordDecl *Record) { if (const FinalAttr *FA = dtor->getAttr()) { Diag(FA->getLocation(), diag::warn_final_dtor_non_final_class) << FA->isSpelledAsSealed() - << FixItHint::CreateRemoval(FA->getLocation()) << FixItHint::CreateInsertion( getLocForEndOfToken(Record->getLocation()), (FA->isSpelledAsSealed() ? " sealed" : " final")); diff --git a/clang/test/SemaCXX/warn-final-dtor-non-final-class.cpp b/clang/test/SemaCXX/warn-final-dtor-non-final-class.cpp index fdfe2ee..a96aa44 100644 --- a/clang/test/SemaCXX/warn-final-dtor-non-final-class.cpp +++ b/clang/test/SemaCXX/warn-final-dtor-non-final-class.cpp @@ -8,7 +8,6 @@ class A { class B { // expected-note {{mark 'B' as 'final' to silence this warning}} // CHECK: fix-it:"{{.*}}":{[[@LINE-1]]:8-[[@LINE-1]]:8}:" final" virtual ~B() final; // expected-warning {{class with destructor marked 'final' cannot be inherited from}} - // CHECK: fix-it:"{{.*}}":{[[@LINE-1]]:18-[[@LINE-1]]:23}:"" }; class C final { -- 2.7.4