From 5485bf7b1bd2f88ecb19c10777a09858a9624b1c Mon Sep 17 00:00:00 2001 From: Samuel Pitoiset Date: Thu, 16 Jun 2022 14:49:24 +0200 Subject: [PATCH] aco: fix validation of SOP1 instructions without definitions MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Like s_setpc_b64. Cc: mesa-stable Signed-off-by: Samuel Pitoiset Reviewed-by: Timur Kristóf Part-of: --- src/amd/compiler/aco_validate.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/amd/compiler/aco_validate.cpp b/src/amd/compiler/aco_validate.cpp index f0da221..dd474ef 100644 --- a/src/amd/compiler/aco_validate.cpp +++ b/src/amd/compiler/aco_validate.cpp @@ -379,8 +379,9 @@ validate_ir(Program* program) } if (instr->isSOP1() || instr->isSOP2()) { - check(instr->definitions[0].getTemp().type() == RegType::sgpr, - "Wrong Definition type for SALU instruction", instr.get()); + if (!instr->definitions.empty()) + check(instr->definitions[0].getTemp().type() == RegType::sgpr, + "Wrong Definition type for SALU instruction", instr.get()); for (const Operand& op : instr->operands) { check(op.isConstant() || op.regClass().type() <= RegType::sgpr, "Wrong Operand type for SALU instruction", instr.get()); -- 2.7.4