From 547684739c528b48935c86a515f5ddddd3a327a3 Mon Sep 17 00:00:00 2001 From: "zandobersek@gmail.com" Date: Mon, 2 Jul 2012 17:56:09 +0000 Subject: [PATCH] [Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt https://bugs.webkit.org/show_bug.cgi?id=85591 Reviewed by Martin Robinson. Create a new category for test failures that only fail on specific architecture. Tests under this category are essentially marked as flaky, but in reality only fail on the build architecture under which they are listed. This is a convenient workaround for keeping tests from being recognized as newly-passing on architectures where the failure does not occur. * platform/gtk/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121694 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- LayoutTests/ChangeLog | 15 +++++++++ LayoutTests/platform/gtk/TestExpectations | 53 +++++++++++++++++++------------ 2 files changed, 47 insertions(+), 21 deletions(-) diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog index 419d8e0..150b667 100644 --- a/LayoutTests/ChangeLog +++ b/LayoutTests/ChangeLog @@ -1,5 +1,20 @@ 2012-07-02 Zan Dobersek + [Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt + https://bugs.webkit.org/show_bug.cgi?id=85591 + + Reviewed by Martin Robinson. + + Create a new category for test failures that only fail on specific architecture. Tests + under this category are essentially marked as flaky, but in reality only fail on the + build architecture under which they are listed. This is a convenient workaround for + keeping tests from being recognized as newly-passing on architectures where the failure + does not occur. + + * platform/gtk/TestExpectations: + +2012-07-02 Zan Dobersek + Clean up slow HTTP tests on GTK platform Rubber-stamped by Martin Robinson. diff --git a/LayoutTests/platform/gtk/TestExpectations b/LayoutTests/platform/gtk/TestExpectations index d8acddf..b532ad4 100644 --- a/LayoutTests/platform/gtk/TestExpectations +++ b/LayoutTests/platform/gtk/TestExpectations @@ -25,7 +25,11 @@ // 5. TESTS TIMING OUT // Please open a bug for each test timing out with any important information. -// 6. TESTS FAILING +// 6. TESTS WITH ARCHITECTURE-SPECIFIC RESULTS +// Tests with different results (of which at least one is failure) on 32-bit and 64-bit builders. +// These tests are essentially marked as flaky, but are noted as failing only on specific architecture. + +// 7. TESTS FAILING // Each test should (eventually) have a bug. Missing DRT features also go here. ////////////////////////////////////////////////////////////////////////////////////////// @@ -351,7 +355,7 @@ BUGWK63611 DEBUG : editing/pasteboard/interchange-newline-2.html = CRASH PASS BUGWK85811 DEBUG : fast/events/message-port-close.html = CRASH PASS BUGWK86443 : plugins/npruntime/delete-plugin-within-getProperty.html = CRASH -BUGWK86443 : plugins/npruntime/delete-plugin-within-invoke.html = CRASH +BUGWK86443 DEBUG : plugins/npruntime/delete-plugin-within-invoke.html = CRASH BUGWK86176 DEBUG : ietestcenter/css3/valuesandunits/units-000.htm = CRASH @@ -474,6 +478,32 @@ BUGWK84676 SKIP : fast/files/file-reader-event-listener.html = TIMEOUT // End of Tests timing out ////////////////////////////////////////////////////////////////////////////////////////// +////////////////////////////////////////////////////////////////////////////////////////// +// Tests with architecture-specific results +////////////////////////////////////////////////////////////////////////////////////////// + +// Fail on 32-bit release builders +BUGWK84857 : fast/repaint/moving-shadow-on-container.html = PASS TEXT +BUGWK84857 : fast/repaint/moving-shadow-on-path.html = PASS TEXT +BUGWK43568 : sputnik/Conformance/15_Native_Objects/15.8_Math/15.8.2/15.8.2.16_sin/S15.8.2.16_A7.html = PASS TEXT +BUGWK43568 : sputnik/Conformance/15_Native_Objects/15.8_Math/15.8.2/15.8.2.18_tan/S15.8.2.18_A7.html = PASS TEXT +BUGWK62204 : svg/W3C-SVG-1.1/paths-data-03-f.svg = PASS TEXT +BUGWKGTK : svg/css/composite-shadow-example.html = PASS TEXT +BUGWKGTK : svg/css/composite-shadow-with-opacity.html = PASS TEXT +BUGWKGTK : svg/css/stars-with-shadow.html = PASS TEXT + +// Fail on 64-bit release and debug builders +BUGWKGTK : sputnik/Unicode/Unicode_510/S7.6_A3.2.html = PASS TEXT +BUGWKGTK : sputnik/Unicode/Unicode_510/S7.6_A5.3_T1.html = PASS TEXT +BUGWKGTK : sputnik/Unicode/Unicode_510/S7.6_A5.3_T2.html = PASS TEXT +BUGWK89099 : svg/transforms/transformed-text-fill-pattern.html = PASS IMAGE + +// Fails on 32-bit release and 64-bit debug builders +BUGWK83560 : fast/events/drop-with-file-paths.html = PASS TEXT + +////////////////////////////////////////////////////////////////////////////////////////// +// End of tests with architecture-specific results +////////////////////////////////////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////////////////////////////////// // Tests failing @@ -887,8 +917,6 @@ BUGWKGTK : http/tests/security/dataTransfer-set-data-file-url.html = TEXT BUGWKGTK : fast/events/ondragenter.html = TEXT // Remaining Sputnik failures -BUGWK43568 : sputnik/Conformance/15_Native_Objects/15.8_Math/15.8.2/15.8.2.16_sin/S15.8.2.16_A7.html = TEXT -BUGWK43568 : sputnik/Conformance/15_Native_Objects/15.8_Math/15.8.2/15.8.2.18_tan/S15.8.2.18_A7.html = TEXT BUGWK43568 : sputnik/Unicode/Unicode_510/S7.6_A3.1.html = TEXT // The following Sputnik tests fail on the 32bit release bot @@ -898,9 +926,6 @@ BUGWKGTK : sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.3/S15.9.3.1_A5_T BUGWKGTK : sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.3/S15.9.3.1_A5_T4.html = TEXT BUGWKGTK : sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.3/S15.9.3.1_A5_T5.html = TEXT BUGWKGTK : sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.3/S15.9.3.1_A5_T6.html = TEXT -BUGWKGTK : sputnik/Unicode/Unicode_510/S7.6_A5.3_T1.html = TEXT -BUGWKGTK : sputnik/Unicode/Unicode_510/S7.6_A5.3_T2.html = TEXT -BUGWKGTK : sputnik/Unicode/Unicode_510/S7.6_A3.2.html = TEXT // r65681 broke a couple GTK+ a11y tests BUGWK44316 : platform/gtk/accessibility/object-attributes.html = TEXT @@ -1044,18 +1069,10 @@ BUGWK84700 : fast/dom/Window/window-postmessage-clone.html = TEXT BUGWK73003 : editing/spelling/spellcheck-async.html = TEXT -// 1 pixel difference between 64-bits and 32-bits -// Some of these also present rounding issues and xx.00 vs xx. BUGWK62204 : svg/custom/relative-sized-use-without-attributes-on-symbol.xhtml = TEXT BUGWK62204 : svg/custom/use-on-symbol-inside-pattern.svg = TEXT -BUGWK62204 : svg/W3C-SVG-1.1/paths-data-03-f.svg = TEXT BUGWK62204 : svg/W3C-SVG-1.1/animate-elem-04-t.svg = TEXT -// Floating point inconsistencies between 32-bit and 64-bit bots -BUGWKGTK : svg/css/composite-shadow-example.html = TEXT -BUGWKGTK : svg/css/composite-shadow-with-opacity.html = TEXT -BUGWKGTK : svg/css/stars-with-shadow.html = TEXT - BUGWK78673 : svg/animations/animate-text-nested-transforms.html = TEXT BUGWK73409 : fast/forms/textarea-placeholder-set-attribute.html = IMAGE @@ -1094,8 +1111,6 @@ BUGWK82020 : plugins/netscape-dom-access-and-reload.html = TEXT // The inner should now grow to take the full cell's height. BUGWKGTK : fast/table/colspanMinWidth-vertical.html = TEXT -BUGWK83560 : fast/events/drop-with-file-paths.html = TEXT - // EditorClient::checkTextOfParagraph() is not implemented. BUGWKGTK : editing/spelling/spelling-marker-description.html = TEXT @@ -1121,9 +1136,6 @@ BUGWK84692 : fast/events/attempt-scroll-with-no-scrollbars.html = TEXT BUGWK84701 : fast/block/line-layout/selection-highlight-overlap.html = IMAGE -BUGWK84857 : fast/repaint/moving-shadow-on-container.html = TEXT -BUGWK84857 : fast/repaint/moving-shadow-on-path.html = TEXT - BUGWK85376 : fullscreen/video-controls-drag.html = TEXT BUGWK84759 : ietestcenter/css3/multicolumn/column-containing-block-001.htm = IMAGE @@ -1190,7 +1202,6 @@ BUGWK86771 SKIP : fast/dom/gc-10.html = TEXT BUGWK88961 : http/tests/misc/redirect-to-about-blank.html = TEXT BUGWK86971 : svg/hittest/svg-shapes-non-scale-stroke.html = TEXT -BUGWK89099 : svg/transforms/transformed-text-fill-pattern.html = IMAGE BUGWK87088 : fast/js/names.html = TEXT -- 2.7.4