From 5468ded718cb49765454e5f778bafa3f47cb6f7b Mon Sep 17 00:00:00 2001 From: Rafael Espindola Date: Wed, 12 Nov 2014 02:30:38 +0000 Subject: [PATCH] Make readBytes pure virtual. Every real implementation has it. llvm-svn: 221758 --- llvm/include/llvm/Support/MemoryObject.h | 3 ++- llvm/lib/Support/MemoryObject.cpp | 19 ------------------- 2 files changed, 2 insertions(+), 20 deletions(-) diff --git a/llvm/include/llvm/Support/MemoryObject.h b/llvm/include/llvm/Support/MemoryObject.h index fcc6bf7..dc5106e 100644 --- a/llvm/include/llvm/Support/MemoryObject.h +++ b/llvm/include/llvm/Support/MemoryObject.h @@ -51,7 +51,8 @@ public: /// and large enough to hold size bytes. /// @result - 0 if successful; -1 if not. Failure may be due to a /// bounds violation or an implementation-specific error. - virtual int readBytes(uint64_t address, uint64_t size, uint8_t *buf) const; + virtual int readBytes(uint64_t address, uint64_t size, + uint8_t *buf) const = 0; }; } diff --git a/llvm/lib/Support/MemoryObject.cpp b/llvm/lib/Support/MemoryObject.cpp index fe5fa871..d796acf 100644 --- a/llvm/lib/Support/MemoryObject.cpp +++ b/llvm/lib/Support/MemoryObject.cpp @@ -12,22 +12,3 @@ using namespace llvm; MemoryObject::~MemoryObject() { } - -int MemoryObject::readBytes(uint64_t address, - uint64_t size, - uint8_t* buf) const { - uint64_t current = address; - uint64_t limit = getExtent(); - - if (current + size > limit) - return -1; - - while (current - address < size) { - if (readByte(current, &buf[(current - address)])) - return -1; - - current++; - } - - return 0; -} -- 2.7.4