From 5462edbc9b85a8a05176d6d1da43569f150e37eb Mon Sep 17 00:00:00 2001 From: Robert Baldyga Date: Wed, 6 Aug 2014 07:37:30 +0200 Subject: [PATCH] drm/exynos: hdmi: fix macros for audio registers This patch fix two things: - Remove duplicated HDMI_I2S_SEL_SDATA2(x) macro definition, add missing HDMI_I2S_SEL_SDATA0(x) macro and fix macro usage. - Fix HDMI_I2S_IN_DISABLE and HDMI_I2S_IN_ENABLE values and fix macro usage. Change-Id: I172913a61011292c3c912a3e8ccd84109924b906 Signed-off-by: Robert Baldyga --- drivers/gpu/drm/exynos/exynos_hdmi.c | 4 ++-- drivers/gpu/drm/exynos/regs-hdmi.h | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c index eabf38b..26a90e0 100644 --- a/drivers/gpu/drm/exynos/exynos_hdmi.c +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c @@ -1083,7 +1083,7 @@ static void hdmi_audio_init(struct hdmi_context *hdata) hdmi_set_acr(sample_rate, acr); hdmi_reg_acr(hdata, acr); - hdmi_reg_writeb(hdata, HDMI_I2S_MUX_CON, HDMI_I2S_IN_DISABLE + hdmi_reg_writeb(hdata, HDMI_I2S_MUX_CON, HDMI_I2S_IN_ENABLE | HDMI_I2S_AUD_I2S | HDMI_I2S_CUV_I2S_ENABLE | HDMI_I2S_MUX_ENABLE); @@ -1107,7 +1107,7 @@ static void hdmi_audio_init(struct hdmi_context *hdata) hdmi_reg_writeb(hdata, HDMI_I2S_PIN_SEL_0, HDMI_I2S_SEL_SCLK(5) | HDMI_I2S_SEL_LRCK(6)); hdmi_reg_writeb(hdata, HDMI_I2S_PIN_SEL_1, HDMI_I2S_SEL_SDATA1(1) - | HDMI_I2S_SEL_SDATA2(4)); + | HDMI_I2S_SEL_SDATA0(4)); hdmi_reg_writeb(hdata, HDMI_I2S_PIN_SEL_2, HDMI_I2S_SEL_SDATA3(1) | HDMI_I2S_SEL_SDATA2(2)); hdmi_reg_writeb(hdata, HDMI_I2S_PIN_SEL_3, HDMI_I2S_SEL_DSD(0)); diff --git a/drivers/gpu/drm/exynos/regs-hdmi.h b/drivers/gpu/drm/exynos/regs-hdmi.h index ef1b3eb..5827883 100644 --- a/drivers/gpu/drm/exynos/regs-hdmi.h +++ b/drivers/gpu/drm/exynos/regs-hdmi.h @@ -455,7 +455,7 @@ /* I2S_PIN_SEL_1 */ #define HDMI_I2S_SEL_SDATA1(x) (((x) & 0x7) << 4) -#define HDMI_I2S_SEL_SDATA2(x) ((x) & 0x7) +#define HDMI_I2S_SEL_SDATA0(x) ((x) & 0x7) /* I2S_PIN_SEL_2 */ #define HDMI_I2S_SEL_SDATA3(x) (((x) & 0x7) << 4) @@ -476,8 +476,8 @@ #define HDMI_I2S_NOISE_FILTER_3_STAGE (2 << 5) #define HDMI_I2S_NOISE_FILTER_4_STAGE (3 << 5) #define HDMI_I2S_NOISE_FILTER_5_STAGE (4 << 5) -#define HDMI_I2S_IN_DISABLE (1 << 4) -#define HDMI_I2S_IN_ENABLE (0 << 4) +#define HDMI_I2S_IN_DISABLE (0 << 4) +#define HDMI_I2S_IN_ENABLE (1 << 4) #define HDMI_I2S_AUD_SPDIF (0 << 2) #define HDMI_I2S_AUD_I2S (1 << 2) #define HDMI_I2S_AUD_DSD (2 << 2) -- 2.7.4