From 544ea71cd770862edbddb8654390444b2e5eac09 Mon Sep 17 00:00:00 2001 From: Argyrios Kyrtzidis Date: Thu, 18 Feb 2016 23:08:36 +0000 Subject: [PATCH] [ASTImporter] Implement missing VisitAccessSpecDecl function in ASTImporter class. Patch by Elisavet Sakellari! llvm-svn: 261274 --- clang/lib/AST/ASTImporter.cpp | 26 ++++++++++++++++++++++++++ clang/test/ASTMerge/Inputs/class1.cpp | 3 ++- clang/test/ASTMerge/Inputs/class2.cpp | 3 ++- clang/test/ASTMerge/class.cpp | 12 ++++++------ 4 files changed, 36 insertions(+), 8 deletions(-) diff --git a/clang/lib/AST/ASTImporter.cpp b/clang/lib/AST/ASTImporter.cpp index 018faff..039ea20 100644 --- a/clang/lib/AST/ASTImporter.cpp +++ b/clang/lib/AST/ASTImporter.cpp @@ -130,6 +130,7 @@ namespace clang { bool IsStructuralMatch(ClassTemplateDecl *From, ClassTemplateDecl *To); bool IsStructuralMatch(VarTemplateDecl *From, VarTemplateDecl *To); Decl *VisitDecl(Decl *D); + Decl *VisitAccessSpecDecl(AccessSpecDecl *D); Decl *VisitTranslationUnitDecl(TranslationUnitDecl *D); Decl *VisitNamespaceDecl(NamespaceDecl *D); Decl *VisitTypedefNameDecl(TypedefNameDecl *D, bool IsAlias); @@ -2316,6 +2317,31 @@ Decl *ASTNodeImporter::VisitTranslationUnitDecl(TranslationUnitDecl *D) { return ToD; } +Decl *ASTNodeImporter::VisitAccessSpecDecl(AccessSpecDecl *D) { + + SourceLocation Loc = Importer.Import(D->getLocation()); + SourceLocation ColonLoc = Importer.Import(D->getColonLoc()); + + // Import the context of this declaration. + DeclContext *DC = Importer.ImportContext(D->getDeclContext()); + if (!DC) + return nullptr; + + AccessSpecDecl *accessSpecDecl + = AccessSpecDecl::Create(Importer.getToContext(), D->getAccess(), + DC, Loc, ColonLoc); + + if (!accessSpecDecl) + return nullptr; + + // Lexical DeclContext and Semantic DeclContext + // is always the same for the accessSpec. + accessSpecDecl->setLexicalDeclContext(DC); + DC->addDeclInternal(accessSpecDecl); + + return accessSpecDecl; +} + Decl *ASTNodeImporter::VisitNamespaceDecl(NamespaceDecl *D) { // Import the major distinguishing characteristics of this namespace. DeclContext *DC, *LexicalDC; diff --git a/clang/test/ASTMerge/Inputs/class1.cpp b/clang/test/ASTMerge/Inputs/class1.cpp index 0cd6565..b0a7645 100644 --- a/clang/test/ASTMerge/Inputs/class1.cpp +++ b/clang/test/ASTMerge/Inputs/class1.cpp @@ -1,5 +1,6 @@ struct A { - int x; + public: + int x; }; struct B : A { diff --git a/clang/test/ASTMerge/Inputs/class2.cpp b/clang/test/ASTMerge/Inputs/class2.cpp index 5d5d9ca..2bed6d7 100644 --- a/clang/test/ASTMerge/Inputs/class2.cpp +++ b/clang/test/ASTMerge/Inputs/class2.cpp @@ -1,5 +1,6 @@ struct A { - int x; + public: + int x; }; struct B : A { diff --git a/clang/test/ASTMerge/class.cpp b/clang/test/ASTMerge/class.cpp index 7b31187..a68a2d1 100644 --- a/clang/test/ASTMerge/class.cpp +++ b/clang/test/ASTMerge/class.cpp @@ -3,12 +3,12 @@ // RUN: %clang_cc1 -ast-merge %t.1.ast -ast-merge %t.2.ast -fsyntax-only %s 2>&1 | FileCheck %s // RUN: %clang_cc1 -ast-merge %t.1.ast -ast-merge %t.2.ast -fsyntax-only %s 2>&1 -Wno-odr -Werror -// CHECK: class1.cpp:5:8: warning: type 'B' has incompatible definitions in different translation units -// CHECK: class1.cpp:6:9: note: field 'y' has type 'float' here -// CHECK: class2.cpp:6:7: note: field 'y' has type 'int' here +// CHECK: class1.cpp:6:8: warning: type 'B' has incompatible definitions in different translation units +// CHECK: class1.cpp:7:9: note: field 'y' has type 'float' here +// CHECK: class2.cpp:7:7: note: field 'y' has type 'int' here // FIXME: we should also complain about mismatched types on the method -// CHECK: class1.cpp:17:6: warning: type 'E' has incompatible definitions in different translation units -// CHECK: class1.cpp:18:3: note: enumerator 'b' with value 1 here -// CHECK: class2.cpp:11:3: note: enumerator 'a' with value 0 here +// CHECK: class1.cpp:18:6: warning: type 'E' has incompatible definitions in different translation units +// CHECK: class1.cpp:19:3: note: enumerator 'b' with value 1 here +// CHECK: class2.cpp:12:3: note: enumerator 'a' with value 0 here -- 2.7.4