From 5407141ac60b6648c9b4d855bc34385abd821844 Mon Sep 17 00:00:00 2001 From: Daniel Juyung Seo Date: Sat, 10 May 2014 23:41:10 +0900 Subject: [PATCH] list: added comments about an unused function. Fixing this issue is not trivial and will bring another issues like crashing. So it is better to fix this in a development phase by refactoring list. To fix this issue, the following are needed: 1. it->walking concept should be adopted instead of using just sd->walking. sd->walking was introduced in beb418d6 2. elm_widget_item_del() should be called instead of the combination of _elm_list_item_free() + elm_widget_item_free() This was introduced in f343011d --- legacy/elementary/src/lib/elm_list.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/legacy/elementary/src/lib/elm_list.c b/legacy/elementary/src/lib/elm_list.c index dedc4a1..0098d1c 100644 --- a/legacy/elementary/src/lib/elm_list.c +++ b/legacy/elementary/src/lib/elm_list.c @@ -1869,6 +1869,12 @@ _item_text_get_hook(const Elm_Object_Item *it, return ((Elm_List_Item *)it)->label; } +/* FIXME: this _item_del_pre_hook is never been called at all! + To fix this, + 1. it->walking concept should be adopted. + 2. elm_widget_item_del() should be called instead of the combination of + _elm_list_item_free() + elm_widget_item_free() + */ static Eina_Bool _item_del_pre_hook(Elm_Object_Item *it) { -- 2.7.4