From 5375f4e6a806ff18bdfb1e1a51cdd0cf546c32b2 Mon Sep 17 00:00:00 2001 From: George Rimar Date: Tue, 26 Sep 2017 13:35:00 +0000 Subject: [PATCH] [ELF] - Remove wrong comment from testcase. It was introduced by me in D37059. Comment was saying that Weak binding is incorrect for 'foo' symbol and that should be true for symbol in final output. But at that place LTO temporarily file was checked, where Weak binding for 'foo' is fine as LTO changes binding for 'LinkerRedefined' symbols internally to prevent IPO. Binding for 'foo' in final output is correctly set to Global and that tested just few lines below in the same testcase. llvm-svn: 314204 --- lld/test/ELF/lto/linker-script-symbols-assign.ll | 2 -- 1 file changed, 2 deletions(-) diff --git a/lld/test/ELF/lto/linker-script-symbols-assign.ll b/lld/test/ELF/lto/linker-script-symbols-assign.ll index c69911d..2ffdc82 100644 --- a/lld/test/ELF/lto/linker-script-symbols-assign.ll +++ b/lld/test/ELF/lto/linker-script-symbols-assign.ll @@ -10,8 +10,6 @@ ; CHECK: Name: foo ; CHECK-NEXT: Value: 0x0 ; CHECK-NEXT: Size: 4 -; FIXME: Binding should be Global here. Symbols redefined in script does not -; receive correct binding and visibility, this is a known bug. ; CHECK-NEXT: Binding: Weak ; CHECK-NEXT: Type: Object ; CHECK-NEXT: Other: 0 -- 2.7.4