From 52d721580ee22525c285e2d13cf3975a7a1b2843 Mon Sep 17 00:00:00 2001 From: csmartdalton Date: Wed, 17 Aug 2016 13:52:15 -0700 Subject: [PATCH] Reduce window rectangles cap to 8 Lowers the cap to 8 and adds a warning message if this value is ever exceeded. The largest (only) implementation currently supports 8, so there isn't yet reason to go higher. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2254013002 Review-Url: https://codereview.chromium.org/2254013002 --- src/gpu/GrCaps.cpp | 2 ++ src/gpu/GrWindowRectangles.h | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gpu/GrCaps.cpp b/src/gpu/GrCaps.cpp index 622c6855fa..9f92210ae8 100644 --- a/src/gpu/GrCaps.cpp +++ b/src/gpu/GrCaps.cpp @@ -141,6 +141,8 @@ void GrCaps::applyOptionsOverrides(const GrContextOptions& options) { fMaxTileSize = options.fMaxTileSizeOverride; } if (fMaxWindowRectangles > GrWindowRectangles::kMaxWindows) { + SkDebugf("WARNING: capping window rectangles at %i. HW advertises support for %i.\n", + GrWindowRectangles::kMaxWindows, fMaxWindowRectangles); fMaxWindowRectangles = GrWindowRectangles::kMaxWindows; } } diff --git a/src/gpu/GrWindowRectangles.h b/src/gpu/GrWindowRectangles.h index 682af9353d..f83f8ddd41 100644 --- a/src/gpu/GrWindowRectangles.h +++ b/src/gpu/GrWindowRectangles.h @@ -13,7 +13,7 @@ class GrWindowRectangles { public: - constexpr static int kMaxWindows = 16; + constexpr static int kMaxWindows = 8; enum class Mode : bool { kExclusive, -- 2.34.1