From 52bd377c00d21a811f55cccf8f9f6e5f510dc4d3 Mon Sep 17 00:00:00 2001 From: SeokHoon Lee Date: Wed, 24 May 2017 13:22:07 +0900 Subject: [PATCH] Fix some crash in create api - There is a availablity in create api, when unaccessable memory position as input parameter(*scmirroring_h). Signed-off-by: SeokHoon Lee Change-Id: Ieb1e2b0f5a530e57f51a7c2af0f138d6aa124295 --- packaging/capi-media-screen-mirroring.spec | 2 +- src/scmirroring_sink.c | 6 ------ src/scmirroring_src.c | 6 ------ 3 files changed, 1 insertion(+), 13 deletions(-) diff --git a/packaging/capi-media-screen-mirroring.spec b/packaging/capi-media-screen-mirroring.spec index 3ae4925..1798a1d 100644 --- a/packaging/capi-media-screen-mirroring.spec +++ b/packaging/capi-media-screen-mirroring.spec @@ -1,6 +1,6 @@ Name: capi-media-screen-mirroring Summary: A screen mirroring library in Tizen C API -Version: 0.1.78 +Version: 0.1.79 Release: 0 Group: Multimedia/API License: Apache-2.0 diff --git a/src/scmirroring_sink.c b/src/scmirroring_sink.c index 7ac4fba..8d160fa 100644 --- a/src/scmirroring_sink.c +++ b/src/scmirroring_sink.c @@ -114,12 +114,6 @@ int scmirroring_sink_create(scmirroring_sink_h *scmirroring_sink) scmirroring_retvm_if(scmirroring_sink == NULL, SCMIRRORING_ERROR_INVALID_PARAMETER, "scmirroring_sink is NULL"); - scmirroring_sink_s *mhandle = (scmirroring_sink_s *)(*scmirroring_sink); - if (mhandle != NULL && mhandle->magic_num == SCMIRRORING_MAGIC_NUMBER) { - scmirroring_error("Already created handle"); - return SCMIRRORING_ERROR_INVALID_PARAMETER; - } - scmirroring_sink_s *handle = (scmirroring_sink_s *)calloc(1, sizeof(scmirroring_sink_s)); scmirroring_retvm_if(handle == NULL, SCMIRRORING_ERROR_OUT_OF_MEMORY, "Fail to allocate memory for handle"); diff --git a/src/scmirroring_src.c b/src/scmirroring_src.c index 3102e9b..11f3837 100644 --- a/src/scmirroring_src.c +++ b/src/scmirroring_src.c @@ -408,12 +408,6 @@ int scmirroring_src_create(scmirroring_src_h *scmirroring) scmirroring_retvm_if(scmirroring == NULL, SCMIRRORING_ERROR_INVALID_PARAMETER, "Handle is NULL"); - scmirroring_src_s *mhandle = (scmirroring_src_s *)(*scmirroring); - if (mhandle != NULL && mhandle->magic_num == SCMIRRORING_MAGIC_NUMBER) { - scmirroring_error("Already created handle"); - return SCMIRRORING_ERROR_INVALID_PARAMETER; - } - _scmirroring = (scmirroring_src_s *)calloc(1, sizeof(scmirroring_src_s)); scmirroring_retvm_if(_scmirroring == NULL, SCMIRRORING_ERROR_OUT_OF_MEMORY, "OUT_OF_MEMORY"); -- 2.34.1