From 52aec3221fa5766c669cfd16e6ba0cf0737d1fff Mon Sep 17 00:00:00 2001 From: Johannes Doerfert Date: Tue, 11 Feb 2020 15:11:32 -0600 Subject: [PATCH] [Attributor][NFC] Clarify the documentation a bit more --- llvm/lib/Transforms/IPO/Attributor.cpp | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/llvm/lib/Transforms/IPO/Attributor.cpp b/llvm/lib/Transforms/IPO/Attributor.cpp index 877557a..86968d1 100644 --- a/llvm/lib/Transforms/IPO/Attributor.cpp +++ b/llvm/lib/Transforms/IPO/Attributor.cpp @@ -374,10 +374,11 @@ static Value *constructPointer(Type *ResTy, Value *Ptr, int64_t Offset, /// will be done by looking through cast instructions, selects, phis, and calls /// with the "returned" attribute. Once we cannot look through the value any /// further, the callback \p VisitValueCB is invoked and passed the current -/// value, the \p State, and a flag to indicate if we stripped anything (=the -/// value used for the callback is not the value associated with \p IRP). To -/// limit how much effort is invested, we will never visit more values than -/// specified by \p MaxValues. +/// value, the \p State, and a flag to indicate if we stripped anything. +/// Stripped means that we unpacked the value associated with \p IRP at least +/// once. Note that the value used for the callback may still be the value +/// associated with \p IRP (due to PHIs). To limit how much effort is invested, +/// we will never visit more values than specified by \p MaxValues. template static bool genericValueTraversal( Attributor &A, IRPosition IRP, const AAType &QueryingAA, StateTy &State, -- 2.7.4