From 524649797fb4f2b078526a40973251a1cdace82f Mon Sep 17 00:00:00 2001
From: Kevin Sawicki <kevinsawicki@gmail.com>
Date: Tue, 15 Dec 2015 16:22:31 -0800
Subject: [PATCH] Make companyName and submitURL required options

---
 atom/common/api/lib/crash-reporter.coffee | 11 ++++++++---
 atom/common/api/lib/deprecate.coffee      |  6 +++++-
 2 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/atom/common/api/lib/crash-reporter.coffee b/atom/common/api/lib/crash-reporter.coffee
index fb0f1eb..e1bfa15 100644
--- a/atom/common/api/lib/crash-reporter.coffee
+++ b/atom/common/api/lib/crash-reporter.coffee
@@ -19,8 +19,6 @@ class CrashReporter
     {app} = if process.type is 'browser' then electron else electron.remote
 
     @productName ?= app.getName()
-    companyName ?= 'GitHub, Inc'
-    submitURL ?= 'http://54.249.141.255:1127/post'
     autoSubmit ?= true
     ignoreSystemCrashHandler ?= false
     extra ?= {}
@@ -29,6 +27,14 @@ class CrashReporter
     extra._companyName ?= companyName
     extra._version ?= app.getVersion()
 
+    unless companyName?
+      deprecate.log('companyName is now a required option to CrashReporter::start')
+      return
+
+    unless submitURL?
+      deprecate.log('submitURL is now a required option to CrashReporter::start')
+      return
+
     start = => binding.start @productName, companyName, submitURL, autoSubmit, ignoreSystemCrashHandler, extra
 
     if process.platform is 'win32'
@@ -59,6 +65,5 @@ class CrashReporter
         path.join tmpdir, "#{@productName} Crashes", 'uploads.log'
     binding._getUploadedReports log
 
-
 crashRepoter = new CrashReporter
 module.exports = crashRepoter
diff --git a/atom/common/api/lib/deprecate.coffee b/atom/common/api/lib/deprecate.coffee
index 1daf5e4..a7de926 100644
--- a/atom/common/api/lib/deprecate.coffee
+++ b/atom/common/api/lib/deprecate.coffee
@@ -54,7 +54,10 @@ deprecate.event = (emitter, oldName, newName, fn) ->
 
 # Print deprecate warning.
 deprecate.warn = (oldName, newName) ->
-  message = "#{oldName} is deprecated. Use #{newName} instead."
+  deprecate.log("#{oldName} is deprecated. Use #{newName} instead.")
+
+# Print deprecation message
+deprecate.log = (message) ->
   if process.throwDeprecation
     throw new Error(message)
   else if process.traceDeprecation
@@ -62,4 +65,5 @@ deprecate.warn = (oldName, newName) ->
   else
     console.warn "(electron) #{message}"
 
+
 module.exports = deprecate
-- 
2.7.4