From 52198f3a03607170d96946ee15c9946d25758284 Mon Sep 17 00:00:00 2001 From: Jan Kotas Date: Mon, 10 Apr 2017 09:28:38 -0700 Subject: [PATCH] Delete FEATURE_READYTORUN define for CoreLib build (dotnet/coreclr#10840) This define does not have much value for the CoreLib build, and it was missing on arm64. Also deleted dead props and targets files left over from the legacy build Commit migrated from https://github.com/dotnet/coreclr/commit/37a68ef73e9bb664a24455e49eda03a876f76efd --- src/coreclr/clr.coreclr.props | 1 - src/coreclr/clr.defines.targets | 74 ----- src/coreclr/clr.native.targets | 31 -- src/coreclr/clr.props | 315 --------------------- src/coreclr/clr.targets | 94 ------ .../Runtime/Versioning/NonVersionableAttribute.cs | 3 - 6 files changed, 518 deletions(-) delete mode 100644 src/coreclr/clr.native.targets delete mode 100644 src/coreclr/clr.props delete mode 100644 src/coreclr/clr.targets diff --git a/src/coreclr/clr.coreclr.props b/src/coreclr/clr.coreclr.props index c724286..53c66e2 100644 --- a/src/coreclr/clr.coreclr.props +++ b/src/coreclr/clr.coreclr.props @@ -37,7 +37,6 @@ true true - true true true true diff --git a/src/coreclr/clr.defines.targets b/src/coreclr/clr.defines.targets index 8958c30..6edd968 100644 --- a/src/coreclr/clr.defines.targets +++ b/src/coreclr/clr.defines.targets @@ -1,78 +1,5 @@ - $(CDefines);WIN32_LEAN_AND_MEAN=1 - $(CDefines);DEBUGGING_SUPPORTED - $(CDefines);EnC_SUPPORTED - $(CDefines);ENABLE_DOWNLEVEL_FOR_NLS - $(CDefines);FEATURE_APPX - $(CDefines);FEATURE_ARRAYSTUB_AS_IL - $(CDefines);FEATURE_STUBS_AS_IL - $(CDefines);FEATURE_CLASSIC_COMINTEROP - $(CDefines);FEATURE_COLLECTIBLE_TYPES - $(CDefines);FEATURE_COMINTEROP - $(CDefines);FEATURE_ICASTABLE - $(CDefines);FEATURE_COMINTEROP_APARTMENT_SUPPORT - $(CDefines);FEATURE_COMINTEROP_UNMANAGED_ACTIVATION - $(CDefines);FEATURE_COMINTEROP_WINRT_MANAGED_ACTIVATION - $(CDefines);FEATURE_COREFX_GLOBALIZATION - $(CDefines);FEATURE_DBGIPC_TRANSPORT_DI - $(CDefines);FEATURE_DBGIPC_TRANSPORT_VM - $(CDefines);FEATURE_DBG_PUBLISH - $(CDefines);FEATURE_EVENT_TRACE - $(CDefines);FEATURE_EVENTSOURCE_XPLAT - $(CDefines);FEATURE_TIERED_COMPILATION - $(CDefines);FEATURE_FULL_NGEN - $(CDefines);FEATURE_HIJACK - $(CDefines);FEATURE_INTEROP_DEBUGGING - $(CDefines);FEATURE_IPCMAN - $(CDefines);FEATURE_ISOLATED_STORAGE_QUOTA_ENFORCEMENT - $(CDefines);FEATURE_ISYM_READER - $(CDefines);FEATURE_LAZY_COW_PAGES - $(CDefines);FEATURE_LEGACYNETCF_DBG_HOST_CONTROL - $(CDefines);FEATURE_MACL - $(CDefines);FEATURE_MANAGED_ETW - $(CDefines);FEATURE_MANAGED_ETW_CHANNELS - $(CDefines);MDA_SUPPORTED - $(CDefines);FEATURE_MERGE_JIT_AND_ENGINE - $(CDefines);FEATURE_METADATA_EMIT - $(CDefines);FEATURE_METADATA_EMIT_ALL - $(CDefines);FEATURE_METADATA_EMIT_IN_DEBUGGER - $(CDefines);FEATURE_METADATA_INTERNAL_APIS - $(CDefines);FEATURE_METADATA_IN_VM - $(CDefines);FEATURE_METADATA_VALIDATOR - $(CDefines);FEATURE_METADATA_CUSTOM_DATA_SOURCE - $(CDefines);FEATURE_METADATA_DEBUGGEE_DATA_SOURCE - $(CDefines);FEATURE_METADATA_VERIFY_LAYOUTS - $(CDefines);FEATURE_NATIVE_IMAGE_GENERATION - $(CDefines);FEATURE_NONGENERIC_COLLECTIONS - $(CDefines);FEATURE_PAL - $(CDefines);FEATURE_PREJIT - $(CDefines);FEATURE_RANDOMIZED_STRING_HASHING - $(CDefines);FEATURE_REJIT - $(CDefines);FEATURE_SORT_TABLES - $(CDefines);FEATURE_STACK_PROBE - $(CDefines);FEATURE_STANDALONE_SN - $(CDefines);FEATURE_STRONGNAME_DELAY_SIGNING_ALLOWED - $(CDefines);FEATURE_SVR_GC - $(CDefines);FEATURE_PERFMAP - $(CDefines);FEATURE_TYPEEQUIVALENCE - $(CDefines);FEATURE_USE_LCID - $(CDefines);FEATURE_UTILCODE_NO_DEPENDENCIES - $(CDefines);FEATURE_VALIDATOR - $(CDefines);FEATURE_VERSIONING_LOG - $(CDefines);FEATURE_WATSON - $(CDefines);FEATURE_WIN32_REGISTRY - $(CDefines);FEATURE_WINMD_RESILIENT - $(CDefines);PROFILING_SUPPORTED - $(CDefines);UEF_CHAINING_SUPPORTED - $(CDefines);USE_STL - $(CDefines);FEATURE_USE_ASM_GC_WRITE_BARRIERS - $(CDefines);BINDER_DEBUG_LOG - $(CDefines);FEATURE_SYMDIFF - $(CDefines);FEATURE_IMPLICIT_TLS - $(CDefines);FEATURE_READYTORUN - $(CDefines);FEATURE_READYTORUN_COMPILER - $(DefineConstants);BUILDTYPE_RET $(DefineConstants);FEATURE_APPX $(DefineConstants);FEATURE_ARRAYSTUB_AS_IL @@ -107,7 +34,6 @@ $(DefineConstants);FEATURE_USE_ASM_GC_WRITE_BARRIERS $(DefineConstants);BINDER_DEBUG_LOG $(DefineConstants);FEATURE_SYMDIFF - $(DefineConstants);FEATURE_READYTORUN $(DefineConstants);PLATFORM_UNIX diff --git a/src/coreclr/clr.native.targets b/src/coreclr/clr.native.targets deleted file mode 100644 index cd2a522..0000000 --- a/src/coreclr/clr.native.targets +++ /dev/null @@ -1,31 +0,0 @@ - - - - - - - - - - - diff --git a/src/coreclr/clr.props b/src/coreclr/clr.props deleted file mode 100644 index 856bebf..0000000 --- a/src/coreclr/clr.props +++ /dev/null @@ -1,315 +0,0 @@ - - - - - - - - - - - $(_NTDRIVE)$(_NTROOT)\ndp\clr - $(Clrbase)\src\ - - $(IntraPartitionAPIsPath)\$(LibSubPath) - $(IntraPartitionAPIsPath)\CORElib\$(InterApiType)\$(RealBuildArchitecture) - $(ClrLibDest) - - - $(BinariesDirectory)\$(BinariesSubDirectory) - $(IntermediateOutputDirectory)\ - $(BinariesDirectory) - true - $(ClrLibPath) - true - true - $(BinariesDirectory) - - - **##ILLEGAL_ ObjectDirectory##** - **##ILLEGAL_ ObjectDirectory0##** - **##ILLEGAL_ ObjectDirectory1##** - **##ILLEGAL_ ObjectDirectory2##** - - - - true - - - true - WarningControl.h - - $(ForcedIncludeFiles) - Async - Sync - Disabled - $(Fullcxxeh) - false - - - true - - - 0 - - - 0 - - *** CLR Build Error: - *** CLR Trace: - - $(ClAdditionalOptions) /MP - $(ClAdditionalOptions) /GS /d2Zi+ - true - - - - $(ClAdditionalOptions) /homeparams - - - <_BuildArch>$(_BUILDARCH) - - $(CrossTargetArchitecture) - $(BuildArchitecture) - - amd64 - - - $(CDefines);_TARGET_X86_=1; - $(CDefines);_TARGET_AMD64_=1; - $(CDefines);_TARGET_ARM_=1; - $(CDefines);_TARGET_ARM64_=1; - - asm - - $(CDefines);BIT64 - - - core_clr - - $(ClAdditionalOptions) /Zm200 - $(BuildArchitecture);_X86_ - $(BuildArchitecture);_AMD64_ - $(BuildArchitecture);_ARM_ - $(BuildArchitecture);_ARM64_ - - i386 - amd64 - arm - arm64 - - true - - - - - - $(ToolsPath)\$(ToolsArchitecture)\prefast\scripts - prefast.exe $(ClToolPath)\$(ClToolExe) - - - - - - - - - - false - false - false - false - false - true - false - false - false - false - true - true - - true - false - - - - - - - - false - true - - - - - - $(CDefines);NTMAKEENV;_DEBUG - true - - - - false - - - - - $(CDefines);NTMAKEENV;NDEBUG;PERF_TRACKING - - - - - - - true - - - MinSpace - Disabled - - - Disabled - - - - $(CDefines);_BLD_CLR - - $(ExceptionHandling) $(ClAdditionalOptions) /we4640 - - - 0x0600 - - - 0x0602 - - - 6.00 - - - $(ClrOverriddenWin32WinNt) - - - $(CDefines);WINVER=$(Win32WinNt) - - - 4013 - true - 4197,4013 - $(LinkLibIgnore);4254 - false - true - - $(ExternalAPIsPath)\Win8CoreSystem - $(ExternalAPIsPath)\Win9CoreSystem - - $(Clrbase)\src\inc; $(Clrbase)\src\strongname\inc; $(IntraPartitionAPIsPath)\inc; $(UserIncludes); $(ClrIncPath) - $(UserIncludes); $(VCToolsIncPath); $(VCPublicIncPath); - $(UserIncludes); $(CoreSystemSdkPath)\inc; $(CoreSystemSdkPath)\inc\crt; - $(UserIncludes); $(NdpRootIncPath); $(NDP_CommonIncPath) - $(Clrbase)\src\inc\WinRT; $(UserIncludes) - - false - false - false - 1 - - $(ResgenDefines) /define:FEATURE_MACL - $(ResgenDefines) /define:FEATURE_DISPLAY_CULTURE_INFO - $(ResgenDefines) /define:FEATURE_DISPLAY_REGION_INFO - - $(BinariesDirectory) - - - - true - true - - - . - . - . - - - $(CDefines);DBG=1 - - - $(CrtLibPath)\msvcrt$(BuildSuffix)_clr.lib - - $(BinariesDirectory)\ref\ - - - - - - true - false - false - - $(CoreSystemSdkPath)\sdk\lib\mincore\$(BuildArchitecture) - $(ExternalAPIsPath)\Windows\Win7\$(BuildArchitecture) - - $(SdkLibPath)\msvcrt.lib - true - true - true - true - - diff --git a/src/coreclr/clr.targets b/src/coreclr/clr.targets deleted file mode 100644 index 5572178..0000000 --- a/src/coreclr/clr.targets +++ /dev/null @@ -1,94 +0,0 @@ - - - - - $(BinariesDirectory)\ - $(BinariesDirectory)\ - - - - - - - - $(IntermediateOutputDirectory)\sign.txt - - - - - - - - GenerateAssemblyAttributes - Preprocess - - - - - - - - true - false - - - - - - - - - - - - - $(ClrBase)\src\inc - $(Internal_GURIncludes);$(VCPublicIncPath) - $(Internal_GURIncludes);$(EnlistmentRootPath)\ndp\inc\version - $(Internal_GURIncludes);$(EnlistmentRootPath)\InternalAPIs\NDP_Common\Inc - $(Internal_GURIncludes);$(SdkIncPath) - - - - - @(RCResourceFile->'$(IntermediateOutputPath)%(Filename).res') - - - - - - - - - diff --git a/src/coreclr/src/mscorlib/src/System/Runtime/Versioning/NonVersionableAttribute.cs b/src/coreclr/src/mscorlib/src/System/Runtime/Versioning/NonVersionableAttribute.cs index 216a48a..e480995 100644 --- a/src/coreclr/src/mscorlib/src/System/Runtime/Versioning/NonVersionableAttribute.cs +++ b/src/coreclr/src/mscorlib/src/System/Runtime/Versioning/NonVersionableAttribute.cs @@ -25,9 +25,6 @@ using System.Diagnostics; namespace System.Runtime.Versioning { - // This Conditional is here to strip the annotations for targets where ReadyToRun is not supported. - // If this attribute is ever made public, this Conditional should be removed. - [Conditional("FEATURE_READYTORUN")] [AttributeUsage(AttributeTargets.Class | AttributeTargets.Struct | AttributeTargets.Method | AttributeTargets.Constructor, AllowMultiple = false, Inherited = false)] internal sealed class NonVersionableAttribute : Attribute -- 2.7.4