From 5210a63ad9e58139ef378bb6668f2467e307fc70 Mon Sep 17 00:00:00 2001 From: Amitoj Kaur Chawla Date: Thu, 3 Mar 2016 01:32:14 +0530 Subject: [PATCH] staging: lustre: llite: Remove unnecessary test in if condition Remove unnecessary test on `rc` variable since it has already been tested previously. Fixes following smatch warning: drivers/staging/lustre/lustre/llite/llite_lib.c:1331 ll_setattr_raw() warn: we tested 'rc' before and it was 'false' Signed-off-by: Amitoj Kaur Chawla Signed-off-by: Greg Kroah-Hartman --- drivers/staging/lustre/lustre/llite/llite_lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/llite/llite_lib.c b/drivers/staging/lustre/lustre/llite/llite_lib.c index acdae25..6d6bb33 100644 --- a/drivers/staging/lustre/lustre/llite/llite_lib.c +++ b/drivers/staging/lustre/lustre/llite/llite_lib.c @@ -1328,7 +1328,7 @@ int ll_setattr_raw(struct dentry *dentry, struct iattr *attr, bool hsm_import) } /* RPC to MDT is sent, cancel data modification flag */ - if (rc == 0 && (op_data->op_bias & MDS_DATA_MODIFIED)) { + if (op_data->op_bias & MDS_DATA_MODIFIED) { spin_lock(&lli->lli_lock); lli->lli_flags &= ~LLIF_DATA_MODIFIED; spin_unlock(&lli->lli_lock); -- 2.7.4