From 51db958068e1a3cf1321c9d6e89d17d1df3b6bbc Mon Sep 17 00:00:00 2001 From: Chen Qi Date: Fri, 16 Aug 2013 17:38:10 +0800 Subject: [PATCH] init-install.sh: fix to handle the boot partition correctly Previously, the boot partition was created for the target hard drive but there was no corresponding entry for it in /etc/fstab. Besides, even if the boot partition was mounted, it would just result in odd directory hierarchy like /boot/boot/grub. However, what we really need is /boot/grub. This patch fixes this problem. Besides, for future maintance work, this patch also renames some of the intermediate directories. It uses more descriptive names like /tgt_root and /src_root. The name of /ssd is dropped. [YOCTO #5018] (From OE-Core rev: aa67b1333b4774e1845f562085f7048df65a644f) Signed-off-by: Chen Qi Signed-off-by: Saul Wold Signed-off-by: Richard Purdie --- meta/recipes-bsp/grub/grub-2.00/40_custom | 2 +- .../initrdscripts/files/init-install.sh | 62 ++++++++++------------ 2 files changed, 30 insertions(+), 34 deletions(-) diff --git a/meta/recipes-bsp/grub/grub-2.00/40_custom b/meta/recipes-bsp/grub/grub-2.00/40_custom index ba48830..f891b02 100755 --- a/meta/recipes-bsp/grub/grub-2.00/40_custom +++ b/meta/recipes-bsp/grub/grub-2.00/40_custom @@ -5,5 +5,5 @@ exec tail -n +3 $0 # the 'exec tail' line above. menuentry "Linux" { set root=(hd0,1) - linux /boot/vmlinuz root=__ROOTFS__ rw __CONSOLE__ __VIDEO_MODE__ __VGA_MODE__ quiet + linux /vmlinuz root=__ROOTFS__ rw __CONSOLE__ __VIDEO_MODE__ __VGA_MODE__ quiet } diff --git a/meta/recipes-core/initrdscripts/files/init-install.sh b/meta/recipes-core/initrdscripts/files/init-install.sh index c892075..8e433d5 100644 --- a/meta/recipes-core/initrdscripts/files/init-install.sh +++ b/meta/recipes-core/initrdscripts/files/init-install.sh @@ -145,29 +145,32 @@ mkfs.ext3 $rootfs echo "Formatting swap partition...($swap)" mkswap $swap -mkdir /ssd -mkdir /rootmnt -mkdir /bootmnt - -mount $rootfs /ssd -mount -o rw,loop,noatime,nodiratime /media/$1/$2 /rootmnt +mkdir /tgt_root +mkdir /src_root +mkdir -p /boot +# Handling of the target root partition +mount $rootfs /tgt_root +mount -o rw,loop,noatime,nodiratime /media/$1/$2 /src_root echo "Copying rootfs files..." -cp -a /rootmnt/* /ssd - -if [ -d /ssd/etc/ ] ; then - echo "$swap swap swap defaults 0 0" >> /ssd/etc/fstab - +cp -a /src_root/* /tgt_root +if [ -d /tgt_root/etc/ ] ; then + echo "$swap swap swap defaults 0 0" >> /tgt_root/etc/fstab + echo "$bootfs /boot ext3 defaults 1 2" >> /tgt_root/etc/fstab # We dont want udev to mount our root device while we're booting... - if [ -d /ssd/etc/udev/ ] ; then - echo "/dev/${device}" >> /ssd/etc/udev/mount.blacklist + if [ -d /tgt_root/etc/udev/ ] ; then + echo "/dev/${device}" >> /tgt_root/etc/udev/mount.blacklist fi fi +umount /tgt_root +umount /src_root +# Handling of the target boot partition +mount $bootfs /boot +echo "Preparing boot partition..." if [ -f /etc/grub.d/40_custom ] ; then echo "Preparing custom grub2 menu..." - GRUBCFG="/bootmnt/boot/grub/grub.cfg" - mount $bootfs /bootmnt + GRUBCFG="/boot/grub/grub.cfg" mkdir -p $(dirname $GRUBCFG) cp /etc/grub.d/40_custom $GRUBCFG sed -i "s@__ROOTFS__@$rootfs $rootwait@g" $GRUBCFG @@ -177,31 +180,24 @@ if [ -f /etc/grub.d/40_custom ] ; then sed -i "/#/d" $GRUBCFG sed -i "/exec tail/d" $GRUBCFG chmod 0444 $GRUBCFG - umount /bootmnt fi - -umount /ssd -umount /rootmnt - -echo "Preparing boot partition..." -mount $bootfs /ssd -grub-install --root-directory=/ssd /dev/${device} - -echo "(hd0) /dev/${device}" > /ssd/boot/grub/device.map +grub-install /dev/${device} +echo "(hd0) /dev/${device}" > /boot/grub/device.map # If grub.cfg doesn't exist, assume GRUB 0.97 and create a menu.lst -if [ ! -f /ssd/boot/grub/grub.cfg ] ; then +if [ ! -f /boot/grub/grub.cfg ] ; then echo "Preparing custom grub menu..." - echo "default 0" > /ssd/boot/grub/menu.lst - echo "timeout 30" >> /ssd/boot/grub/menu.lst - echo "title Live Boot/Install-Image" >> /ssd/boot/grub/menu.lst - echo "root (hd0,0)" >> /ssd/boot/grub/menu.lst - echo "kernel /boot/vmlinuz root=$rootfs rw $3 $4 quiet" >> /ssd/boot/grub/menu.lst + echo "default 0" > /boot/grub/menu.lst + echo "timeout 30" >> /boot/grub/menu.lst + echo "title Live Boot/Install-Image" >> /boot/grub/menu.lst + echo "root (hd0,0)" >> /boot/grub/menu.lst + echo "kernel /vmlinuz root=$rootfs rw $3 $4 quiet" >> /boot/grub/menu.lst fi -cp /media/$1/vmlinuz /ssd/boot/ +cp /media/$1/vmlinuz /boot/ + +umount /boot -umount /ssd sync echo "Remove your installation media, and press ENTER" -- 2.7.4