From 51c8cfc64c7286ad8a392064cd376bb9974c7bc1 Mon Sep 17 00:00:00 2001 From: mtklein Date: Fri, 11 Mar 2016 12:59:09 -0800 Subject: [PATCH] Revert of When not writing to file in DM, spew verbose output to stderr (patchset #1 id:1 of https://codereview.chromium.org/1788743002/ ) Reason for revert: Looks like not all the bots are using --writePath (think, Valgrind, *SAN) so this causes those bots to spew like crazy. Looks like we need to find a more explicit way to make this mode work. Original issue's description: > When not writing to file in DM, spew verbose output to stderr > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1788743002 > > Committed: https://skia.googlesource.com/skia/+/40dec542cc12b354762bca2c0d68bc419f0cbebd TBR=egdaniel@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1783603006 --- dm/DM.cpp | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/dm/DM.cpp b/dm/DM.cpp index ebe37ae..d558e08 100644 --- a/dm/DM.cpp +++ b/dm/DM.cpp @@ -1303,13 +1303,9 @@ int dm_main(); int dm_main() { setup_crash_handler(); - if (FLAGS_verbose) { - if(!FLAGS_writePath.isEmpty()) { - sk_mkdir(FLAGS_writePath[0]); - gVLog = freopen(SkOSPath::Join(FLAGS_writePath[0], "verbose.log").c_str(), "w", stderr); - } else { - gVLog = stderr; - } + if (FLAGS_verbose && !FLAGS_writePath.isEmpty()) { + sk_mkdir(FLAGS_writePath[0]); + gVLog = freopen(SkOSPath::Join(FLAGS_writePath[0], "verbose.log").c_str(), "w", stderr); } JsonWriter::DumpJson(); // It's handy for the bots to assume this is ~never missing. -- 2.7.4