From 51a888ff48c70aefd85d70f0b5a160a72a338fd8 Mon Sep 17 00:00:00 2001 From: "adamk@chromium.org" Date: Fri, 22 Mar 2013 15:08:30 +0000 Subject: [PATCH] Fix bogus left-shifts in Array tests Review URL: https://codereview.chromium.org/12729014 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14050 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- test/mjsunit/array-splice.js | 10 +++++----- test/mjsunit/array-unshift.js | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/test/mjsunit/array-splice.js b/test/mjsunit/array-splice.js index 0e307b5..be2b106 100644 --- a/test/mjsunit/array-splice.js +++ b/test/mjsunit/array-splice.js @@ -285,8 +285,8 @@ assertFalse(array.hasOwnProperty(15), "array.hasOwnProperty(15)"); assertFalse(array.hasOwnProperty(31), "array.hasOwnProperty(31)"); assertFalse(array.hasOwnProperty(63), "array.hasOwnProperty(63)"); - assertFalse(array.hasOwnProperty(2 << 32 - 1), - "array.hasOwnProperty(2 << 31 - 1)"); + assertFalse(array.hasOwnProperty(Math.pow(2, 32) - 2), + "array.hasOwnProperty(Math.pow(2, 32) - 2)"); } })(); @@ -333,8 +333,8 @@ assertFalse(array.hasOwnProperty(15), "array.hasOwnProperty(15)"); assertFalse(array.hasOwnProperty(31), "array.hasOwnProperty(31)"); assertFalse(array.hasOwnProperty(63), "array.hasOwnProperty(63)"); - assertFalse(array.hasOwnProperty(2 << 32 - 1), - "array.hasOwnProperty(2 << 31 - 1)"); + assertFalse(array.hasOwnProperty(Math.pow(2, 32) - 2), + "array.hasOwnProperty(Math.pow(2, 32) - 2)"); } })(); @@ -357,7 +357,7 @@ (function() { for (var i = 0; i < 7; i++) { try { - new Array((1 << 32) - 3).splice(-1, 0, 1, 2, 3, 4, 5); + new Array(Math.pow(2, 32) - 3).splice(-1, 0, 1, 2, 3, 4, 5); throw 'Should have thrown RangeError'; } catch (e) { assertTrue(e instanceof RangeError); diff --git a/test/mjsunit/array-unshift.js b/test/mjsunit/array-unshift.js index c4cc95c..4010601 100644 --- a/test/mjsunit/array-unshift.js +++ b/test/mjsunit/array-unshift.js @@ -194,7 +194,7 @@ (function() { for (var i = 0; i < 7; i++) { try { - new Array((1 << 32) - 3).unshift(1, 2, 3, 4, 5); + new Array(Math.pow(2, 32) - 3).unshift(1, 2, 3, 4, 5); throw 'Should have thrown RangeError'; } catch (e) { assertTrue(e instanceof RangeError); -- 2.7.4