From 516b01e398c27ec714e74a5ce10d5a37f01e774d Mon Sep 17 00:00:00 2001 From: Cheng Zhao Date: Thu, 28 Jan 2016 22:38:53 +0800 Subject: [PATCH] win: Call _close before close file handle Fix #4258. --- atom/common/asar/archive.cc | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/atom/common/asar/archive.cc b/atom/common/asar/archive.cc index d6abf1c..7527932 100644 --- a/atom/common/asar/archive.cc +++ b/atom/common/asar/archive.cc @@ -130,14 +130,16 @@ Archive::Archive(const base::FilePath& path) Archive::~Archive() { #if defined(OS_WIN) - file_.Close(); - _close(fd_); + if (fd_ != -1) + _close(fd_); #endif } bool Archive::Init() { - if (!file_.IsValid()) + if (!file_.IsValid()) { + LOG(ERROR) << base::File::ErrorToString(file_.error_details()); return false; + } std::vector buf; int len; -- 2.7.4