From 51358672182802e3bb7f334ac60ef89c2ea4a005 Mon Sep 17 00:00:00 2001 From: Vyacheslav Reutskiy Date: Mon, 15 Aug 2016 13:59:46 +0300 Subject: [PATCH] elm_genlist: unhighlight item if it not selected Summary: Main trouble in handle click and double click event. If user hold Esc and do double click on genlist item, it still highlighted but not selected, because between click and double click genlist process a key down event. This patch add check the item state on mouse up, check a item state - if item highlighted but not selected, unhighlight it. @fix Fixes T3986 Test Plan: 1. run elementary_test Genlist 2. hold ESC 3. double-click on few genlist items Reviewers: raster, cedric, NikaWhite Subscribers: seoz, jpeg Maniphest Tasks: T3986 Differential Revision: https://phab.enlightenment.org/D4222 --- src/lib/elementary/elm_genlist.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/lib/elementary/elm_genlist.c b/src/lib/elementary/elm_genlist.c index 16f1906..c17b480 100644 --- a/src/lib/elementary/elm_genlist.c +++ b/src/lib/elementary/elm_genlist.c @@ -4939,6 +4939,9 @@ _item_mouse_up_cb(void *data, } } + if (!it->selected && it->highlighted) + _item_unhighlight(it); + if ((ev->flags != EVAS_BUTTON_NONE) || (ev->event_flags & EVAS_EVENT_FLAG_ON_HOLD) || !it->base->still_in || -- 2.7.4