From 510990bb12d6a2245a7ec29050adb6c1c7149987 Mon Sep 17 00:00:00 2001 From: Father Chrysostomos Date: Sat, 18 Jan 2014 05:36:52 -0800 Subject: [PATCH] =?utf8?q?threads::shared:=20Don=E2=80=99t=20link=20to=20m?= =?utf8?q?oving=20targets?= MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The Scalar::Util documentation has changed, so the links are broken. But we cannot just update the link targets, as threads::shared is living a double life and may be installed along with an older Scalar::Util. --- dist/threads-shared/lib/threads/shared.pm | 8 ++++---- t/porting/known_pod_issues.dat | 1 - 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/dist/threads-shared/lib/threads/shared.pm b/dist/threads-shared/lib/threads/shared.pm index 5a24a98..1337b58 100644 --- a/dist/threads-shared/lib/threads/shared.pm +++ b/dist/threads-shared/lib/threads/shared.pm @@ -336,7 +336,7 @@ then the C substitution will be performed silently. C checks if the specified variable is shared or not. If shared, returns the variable's internal ID (similar to -L). Otherwise, returns C. +C (see L). Otherwise, returns C. if (is_shared($var)) { print("\$var is shared\n"); @@ -584,7 +584,7 @@ the error "lock can only be used on shared values" to occur when you attempt to C<< lock($hashref->{key}) >> or C<< lock($arrayref->[idx]) >> in another thread. -Using L) is unreliable for testing +Using C is unreliable for testing whether or not two shared references are equivalent (e.g., when testing for circular references). Use L, instead: @@ -623,8 +623,8 @@ Either of the following will work instead: ... } -This module supports dual-valued variables created using L). However, while C<$!> acts +This module supports dual-valued variables created using C from +L. However, while C<$!> acts like a dualvar, it is implemented as a tied SV. To propagate its value, use the follow construct, if needed: diff --git a/t/porting/known_pod_issues.dat b/t/porting/known_pod_issues.dat index dff00dd..7861b69 100644 --- a/t/porting/known_pod_issues.dat +++ b/t/porting/known_pod_issues.dat @@ -203,7 +203,6 @@ dist/module-corelist/lib/module/corelist/utils.pm Verbatim line length including dist/selfloader/lib/selfloader.pm Verbatim line length including indents exceeds 79 by 13 dist/storable/storable.pm Verbatim line length including indents exceeds 79 by 4 dist/thread-queue/lib/thread/queue.pm Verbatim line length including indents exceeds 79 by 4 -dist/threads-shared/lib/threads/shared.pm Apparent broken link 3 dist/threads/lib/threads.pm Verbatim line length including indents exceeds 79 by 3 dist/tie-file/lib/tie/file.pm Verbatim line length including indents exceeds 79 by 3 ext/devel-peek/peek.pm ? Should you be using L<...> instead of 2 -- 2.7.4