From 50d705b5b013ae86bc1c718d512f9dd0fd88ddd6 Mon Sep 17 00:00:00 2001 From: Richard Smith Date: Fri, 7 Dec 2012 02:10:28 +0000 Subject: [PATCH] Per [dcl.fct.def.default]p1, don't allow variadic special members to be defaulted. llvm-svn: 169574 --- clang/lib/Sema/SemaDeclCXX.cpp | 4 ++++ .../dcl.fct.def/dcl.fct.def.default/p1.cpp | 26 ++++++++++++++++++++++ 2 files changed, 30 insertions(+) create mode 100644 clang/test/CXX/dcl.decl/dcl.fct.def/dcl.fct.def.default/p1.cpp diff --git a/clang/lib/Sema/SemaDeclCXX.cpp b/clang/lib/Sema/SemaDeclCXX.cpp index 64895d7..88cc0aa 100644 --- a/clang/lib/Sema/SemaDeclCXX.cpp +++ b/clang/lib/Sema/SemaDeclCXX.cpp @@ -4223,6 +4223,10 @@ void Sema::CheckExplicitlyDefaultedSpecialMember(CXXMethodDecl *MD) { Diag(MD->getLocation(), diag::err_defaulted_special_member_params) << CSM << MD->getSourceRange(); HadError = true; + } else if (MD->isVariadic()) { + Diag(MD->getLocation(), diag::err_defaulted_special_member_variadic) + << CSM << MD->getSourceRange(); + HadError = true; } const FunctionProtoType *Type = MD->getType()->getAs(); diff --git a/clang/test/CXX/dcl.decl/dcl.fct.def/dcl.fct.def.default/p1.cpp b/clang/test/CXX/dcl.decl/dcl.fct.def/dcl.fct.def.default/p1.cpp new file mode 100644 index 0000000..e3e19e1 --- /dev/null +++ b/clang/test/CXX/dcl.decl/dcl.fct.def/dcl.fct.def.default/p1.cpp @@ -0,0 +1,26 @@ +// RUN: %clang_cc1 -verify %s -std=c++11 + +// A function that is explicitly defaulted shall +struct A { + // -- be a special member function, + A(int) = default; // expected-error {{only special member functions may be defaulted}} + + // -- have the same declared function type as if it had been implicitly + // declared + void operator=(const A &) = default; // expected-error {{must return 'A &'}} + A(...) = default; // expected-error {{cannot be variadic}} + A(const A &, ...) = default; // expected-error {{cannot be variadic}} + + // (except for possibly differing ref-qualifiers + A &operator=(A &&) & = default; + + // FIXME: + // and except that in the case of a copy constructor or copy assignment + // operator, the parameter type may be "reference to non-const T") + A(A &) = default; // FIXME: expected-error {{must be defaulted outside the class}} + A &operator=(A &) = default; // FIXME: expected-error {{must be defaulted outside the class}} + + // -- not have default arguments + A(double = 0.0) = default; // expected-error {{cannot have default arguments}} + A(const A & = 0) = default; // expected-error {{cannot have default arguments}} +}; -- 2.7.4