From 50bede1bcb83ba468bf6e975d34d1903ced65636 Mon Sep 17 00:00:00 2001 From: "js126.lee" Date: Wed, 14 Dec 2016 13:40:09 +0900 Subject: [PATCH] Fixed bug of gernerating pin during randompin OTM Bug : During generating randompin, the bound of curIndex is one more. Patch 1: Upload patch. Change-Id: I0c6416adaa8f0fbd8eeb936a0cc17b64047b9222 Signed-off-by: js126.lee Reviewed-on: https://gerrit.iotivity.org/gerrit/15579 Reviewed-by: Jongmin Choi Tested-by: jenkins-iotivity Reviewed-by: Randeep Singh (cherry picked from commit 78fdef84ed34707fac4bf3a6f9abf20803046f88) Reviewed-on: https://gerrit.iotivity.org/gerrit/15583 --- resource/csdk/security/src/oxmpincommon.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/resource/csdk/security/src/oxmpincommon.c b/resource/csdk/security/src/oxmpincommon.c index 6fc776b..b817c80 100644 --- a/resource/csdk/security/src/oxmpincommon.c +++ b/resource/csdk/security/src/oxmpincommon.c @@ -151,6 +151,10 @@ static char GenerateRandomPinElement(OicSecPinType_t pinType) { return defaultRetValue; } + else + { + curIndex -= 1; + } return allowedCharacters[OCGetRandomRange(0, curIndex)]; } -- 2.7.4