From 506f8709ceddd26542824d8cb9eac80201d085f1 Mon Sep 17 00:00:00 2001 From: Max Reitz Date: Tue, 17 May 2016 16:41:26 +0200 Subject: [PATCH] block: Drop useless bdrv_new() call bdrv_append_temp_snapshot() uses bdrv_new() to create an empty BDS before invoking bdrv_open() on that BDS. This is probably a relict from when it used to do some modifications on that empty BDS, but now that is unnecessary, so we can just set bs_snapshot to NULL and let bdrv_open() do the rest. Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia Reviewed-by: Kevin Wolf Signed-off-by: Kevin Wolf --- block.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/block.c b/block.c index d287771..f85c5a2 100644 --- a/block.c +++ b/block.c @@ -1470,8 +1470,7 @@ static int bdrv_append_temp_snapshot(BlockDriverState *bs, int flags, qdict_put(snapshot_options, "driver", qstring_from_str("qcow2")); - bs_snapshot = bdrv_new(); - + bs_snapshot = NULL; ret = bdrv_open(&bs_snapshot, NULL, NULL, snapshot_options, flags, &local_err); snapshot_options = NULL; -- 2.7.4