From 506154f704dcb9185dadcd655fd6d0603916ea97 Mon Sep 17 00:00:00 2001 From: Iago Toral Quiroga Date: Thu, 23 Jun 2016 10:35:50 +0200 Subject: [PATCH] i965/vec4: extend the DWORD multiply DepCtrl restriction to all gen8 platforms v2: - Add Broxton as Intel's internal PRMs says that it is needed (Matt). Reviewed-by: Matt Turner --- src/mesa/drivers/dri/i965/brw_vec4.cpp | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp b/src/mesa/drivers/dri/i965/brw_vec4.cpp index 5ff0d53..c461f26 100644 --- a/src/mesa/drivers/dri/i965/brw_vec4.cpp +++ b/src/mesa/drivers/dri/i965/brw_vec4.cpp @@ -908,11 +908,14 @@ vec4_visitor::is_dep_ctrl_unsafe(const vec4_instruction *inst) (reg.type == BRW_REGISTER_TYPE_UD || \ reg.type == BRW_REGISTER_TYPE_D) - /* "When source or destination datatype is 64b or operation is integer DWord + /* From the Cherryview and Broadwell PRMs: + * + * "When source or destination datatype is 64b or operation is integer DWord * multiply, DepCtrl must not be used." - * May apply to future SoCs as well. + * + * SKL PRMs don't include this restriction though. */ - if (devinfo->is_cherryview) { + if (devinfo->gen == 8 || devinfo->is_broxton) { if (inst->opcode == BRW_OPCODE_MUL && IS_DWORD(inst->src[0]) && IS_DWORD(inst->src[1])) -- 2.7.4