From 50138abb5a0328b530723dfef5e9a8ac9dea2692 Mon Sep 17 00:00:00 2001 From: Alyssa Rosenzweig Date: Mon, 10 Feb 2020 08:56:33 -0500 Subject: [PATCH] panfrost: Rename unknown2_8 to padding It's zero everywhere. Signed-off-by: Alyssa Rosenzweig Part-of: --- src/panfrost/include/panfrost-job.h | 3 +-- src/panfrost/pandecode/decode.c | 6 ++++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/panfrost/include/panfrost-job.h b/src/panfrost/include/panfrost-job.h index 7002776..940b586 100644 --- a/src/panfrost/include/panfrost-job.h +++ b/src/panfrost/include/panfrost-job.h @@ -614,8 +614,7 @@ struct mali_shader_meta { } midgard2; }; - /* zero on bifrost */ - u32 unknown2_8; + u32 padding; /* Blending information for the older non-MRT Midgard HW. Check for * MALI_HAS_BLEND_SHADER to decide how to interpret. diff --git a/src/panfrost/pandecode/decode.c b/src/panfrost/pandecode/decode.c index ec53cd7..e523128 100644 --- a/src/panfrost/pandecode/decode.c +++ b/src/panfrost/pandecode/decode.c @@ -2270,8 +2270,10 @@ pandecode_vertex_tiler_postfix_pre( pandecode_log("},\n"); } - if (s->unknown2_8) - pandecode_prop("unknown2_8 = 0x%" PRIx32, s->unknown2_8); + if (s->padding) { + pandecode_msg("XXX: shader padding tripped\n"); + pandecode_prop("padding = 0x%" PRIx32, s->padding); + } if (!is_bifrost) { /* TODO: Blend shaders routing/disasm */ -- 2.7.4