From 4ffc6f3b833817f2dc57917b80f8c5530721e706 Mon Sep 17 00:00:00 2001 From: Nico Weber Date: Fri, 18 Nov 2022 16:02:34 -0500 Subject: [PATCH] [bolt] Stop setting config.llvm_plugin_ext in lit.site.cfg.py.in config.llvm_plugin_ext is used by lit to set the %pluginext substitution. bolt's tests don't use %pluginext, so they don't need to set config.llvm_plugin_ext. Differential Revision: https://reviews.llvm.org/D138325 --- bolt/test/lit.site.cfg.py.in | 1 - llvm/utils/gn/secondary/bolt/test/BUILD.gn | 8 -------- 2 files changed, 9 deletions(-) diff --git a/bolt/test/lit.site.cfg.py.in b/bolt/test/lit.site.cfg.py.in index 78e1448..e357c48 100644 --- a/bolt/test/lit.site.cfg.py.in +++ b/bolt/test/lit.site.cfg.py.in @@ -9,7 +9,6 @@ config.bolt_enable_runtime = @BOLT_ENABLE_RUNTIME@ config.llvm_tools_dir = lit_config.substitute("@LLVM_TOOLS_DIR@") config.llvm_libs_dir = lit_config.substitute("@LLVM_LIBS_DIR@") config.llvm_shlib_dir = lit_config.substitute("@SHLIBDIR@") -config.llvm_plugin_ext = "@LLVM_PLUGIN_EXT@" config.lit_tools_dir = "@LLVM_LIT_TOOLS_DIR@" config.host_triple = "@LLVM_HOST_TRIPLE@" config.target_triple = "@LLVM_TARGET_TRIPLE@" diff --git a/llvm/utils/gn/secondary/bolt/test/BUILD.gn b/llvm/utils/gn/secondary/bolt/test/BUILD.gn index 30af95f..1a8b76a 100644 --- a/llvm/utils/gn/secondary/bolt/test/BUILD.gn +++ b/llvm/utils/gn/secondary/bolt/test/BUILD.gn @@ -55,14 +55,6 @@ write_lit_config("lit_site_cfg") { } else { assert(false, "unimplemented host_cpu " + host_cpu) } - - if (host_os == "mac") { - extra_values += [ "LLVM_PLUGIN_EXT=.dylib" ] - } else if (host_os == "win") { - extra_values += [ "LLVM_PLUGIN_EXT=.dll" ] - } else { - extra_values += [ "LLVM_PLUGIN_EXT=.so" ] - } } write_lit_config("lit_unit_site_cfg") { -- 2.7.4