From 4f935e1e7f59062afe01e1113db1703e6194dc28 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Tim-Philipp=20M=C3=BCller?= Date: Thu, 29 Nov 2018 11:24:39 +0000 Subject: [PATCH] cc708overlay: fix deadlock We would forget to unlock when a caption data buffer is deemed out of segment, which makes everything lock up next time buffers are received. --- ext/closedcaption/gstceaccoverlay.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ext/closedcaption/gstceaccoverlay.c b/ext/closedcaption/gstceaccoverlay.c index a9db124..1fd38d9 100644 --- a/ext/closedcaption/gstceaccoverlay.c +++ b/ext/closedcaption/gstceaccoverlay.c @@ -1713,6 +1713,8 @@ gst_cea_cc_overlay_cc_chain (GstPad * pad, GstObject * parent, overlay->decoder->current_time = GST_BUFFER_PTS (buffer); } gst_buffer_unmap (buffer, &buf_map); + } else { + GST_CEA_CC_OVERLAY_UNLOCK (overlay); } beach: -- 2.7.4