From 4f58fe67d23f225da9915d9595ad4bf11743ff19 Mon Sep 17 00:00:00 2001 From: SoroushIMG Date: Sun, 5 Feb 2023 17:31:47 +0000 Subject: [PATCH] zink: fix leak when rebinding same image surface simple way to reproduce this is to run these 4 together: KHR-GL46.gpu_shader5.images_array_indexing KHR-GL46.shader_image_load_store.advanced-allMips KHR-GL46.shader_image_load_store.advanced-sso-simple KHR-GL46.shader_image_load_store.incomplete_textures cc: mesa-stable Part-of: (cherry picked from commit 104040b5c7135403194005951e57197ef76438a6) --- .pick_status.json | 2 +- src/gallium/drivers/zink/zink_context.c | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.pick_status.json b/.pick_status.json index bd02a99..6127275 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -1192,7 +1192,7 @@ "description": "zink: fix leak when rebinding same image surface", "nominated": true, "nomination_type": 0, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": null }, diff --git a/src/gallium/drivers/zink/zink_context.c b/src/gallium/drivers/zink/zink_context.c index 0cbb0cc..3360ae9 100644 --- a/src/gallium/drivers/zink/zink_context.c +++ b/src/gallium/drivers/zink/zink_context.c @@ -1737,8 +1737,11 @@ zink_set_shader_images(struct pipe_context *pctx, res->image_bind_count[p_stage == MESA_SHADER_COMPUTE]++; update_res_bind_count(ctx, res, p_stage == MESA_SHADER_COMPUTE, false); unbind_shader_image(ctx, p_stage, start_slot + i); + image_view->surface = surface; + } else { + /* create_image_surface will always increment ref */ + zink_surface_reference(zink_screen(ctx->base.screen), &surface, NULL); } - image_view->surface = surface; finalize_image_bind(ctx, res, p_stage == MESA_SHADER_COMPUTE); zink_batch_resource_usage_set(&ctx->batch, res, zink_resource_access_is_write(access), false); -- 2.7.4