From 4f2c95c524c209ea3a5b32dbee1fc71308a6aade Mon Sep 17 00:00:00 2001 From: Ji-hoon Lee Date: Mon, 13 Apr 2020 20:19:16 +0900 Subject: [PATCH] Replace int with pid_t where applicable Change-Id: Ic388b17e4b37072eda5861d39b92345b8553d55b --- inc/application_manager.h | 4 ++-- inc/application_manager_aul.h | 4 ++-- src/application_manager_aul.cpp | 4 ++-- tests/utc/client-manager/test_client_manager.cpp | 4 ++-- tests/utc/service-main/test_service_main.cpp | 4 ++-- 5 files changed, 10 insertions(+), 10 deletions(-) diff --git a/inc/application_manager.h b/inc/application_manager.h index 0bb6fea..1effd84 100644 --- a/inc/application_manager.h +++ b/inc/application_manager.h @@ -27,11 +27,11 @@ extern "C" { class IApplicationManager { public: - virtual bool is_application_running(int pid) = 0; + virtual bool is_application_running(pid_t pid) = 0; virtual bool is_application_running(const std::string& appid) = 0; virtual bool bring_app_to_foreground(const std::string& appid) = 0; virtual bool launch_app_async(const std::string& appid, bool background) = 0; - virtual boost::optional get_appid_by_pid(int pid) = 0; + virtual boost::optional get_appid_by_pid(pid_t pid) = 0; }; #ifdef __cplusplus diff --git a/inc/application_manager_aul.h b/inc/application_manager_aul.h index 0de9479..4b46f59 100644 --- a/inc/application_manager_aul.h +++ b/inc/application_manager_aul.h @@ -29,11 +29,11 @@ public: CApplicationManagerAul(); ~CApplicationManagerAul(); - virtual bool is_application_running(int pid) override; + virtual bool is_application_running(pid_t pid) override; virtual bool is_application_running(const std::string& appid) override; virtual bool bring_app_to_foreground(const std::string& appid) override; virtual bool launch_app_async(const std::string& appid, bool background) override; - virtual boost::optional get_appid_by_pid(int pid) override; + virtual boost::optional get_appid_by_pid(pid_t pid) override; }; #ifdef __cplusplus diff --git a/src/application_manager_aul.cpp b/src/application_manager_aul.cpp index 9418b96..41ae5f2 100644 --- a/src/application_manager_aul.cpp +++ b/src/application_manager_aul.cpp @@ -28,7 +28,7 @@ CApplicationManagerAul::~CApplicationManagerAul() { } -bool CApplicationManagerAul::is_application_running(int pid) +bool CApplicationManagerAul::is_application_running(pid_t pid) { int status = aul_app_get_status_bypid(pid); if (0 > status) { @@ -98,7 +98,7 @@ bool CApplicationManagerAul::launch_app_async(const std::string& appid, bool bac return ret; } -boost::optional CApplicationManagerAul::get_appid_by_pid(int pid) +boost::optional CApplicationManagerAul::get_appid_by_pid(pid_t pid) { boost::optional ret; diff --git a/tests/utc/client-manager/test_client_manager.cpp b/tests/utc/client-manager/test_client_manager.cpp index d23428d..da5cb94 100644 --- a/tests/utc/client-manager/test_client_manager.cpp +++ b/tests/utc/client-manager/test_client_manager.cpp @@ -26,11 +26,11 @@ public: CDummyApplicationManager() {}; virtual ~CDummyApplicationManager() {}; - bool is_application_running(int pid) { return true; } + bool is_application_running(pid_t pid) { return true; } bool is_application_running(const std::string& appid) { return true; } bool bring_app_to_foreground(const std::string& appid) { return true; } bool launch_app_async(const std::string& appid, bool background) { return true; } - boost::optional get_appid_by_pid(int pid) { return boost::optional{}; } + boost::optional get_appid_by_pid(pid_t pid) { return boost::optional{}; } }; class StorageWithNoClient : public testing::Test diff --git a/tests/utc/service-main/test_service_main.cpp b/tests/utc/service-main/test_service_main.cpp index b7313c5..b14cf72 100644 --- a/tests/utc/service-main/test_service_main.cpp +++ b/tests/utc/service-main/test_service_main.cpp @@ -28,7 +28,7 @@ public: CDummyApplicationManager() {}; ~CDummyApplicationManager() {}; - bool is_application_running(int pid) override { return false; } + bool is_application_running(pid_t pid) override { return false; } bool is_application_running(const std::string& appid) override { return false; } bool bring_app_to_foreground(const std::string& appid) override { @@ -41,7 +41,7 @@ public: launched_option_background = background; return true; } - boost::optional get_appid_by_pid(int pid) override { return boost::optional{}; } + boost::optional get_appid_by_pid(pid_t pid) override { return boost::optional{}; } public: boost::optional launched_appid; boost::optional launched_option_background; -- 2.7.4