From 4f257c73f53d454adb106301b5bfcf57c79ba485 Mon Sep 17 00:00:00 2001 From: Maryam Ariyan Date: Wed, 22 Jul 2020 18:20:55 -0700 Subject: [PATCH] Disabled tests with the PlatformDetection.IsPreciseGcSupported (#39796) --- .../Microsoft.Extensions.Http/tests/DefaultHttpClientFactoryTest.cs | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/libraries/Microsoft.Extensions.Http/tests/DefaultHttpClientFactoryTest.cs b/src/libraries/Microsoft.Extensions.Http/tests/DefaultHttpClientFactoryTest.cs index e06530d..72d89b1 100644 --- a/src/libraries/Microsoft.Extensions.Http/tests/DefaultHttpClientFactoryTest.cs +++ b/src/libraries/Microsoft.Extensions.Http/tests/DefaultHttpClientFactoryTest.cs @@ -341,8 +341,7 @@ namespace Microsoft.Extensions.Http Assert.NotSame(activeEntry1.Handler, activeEntry2.Handler); } - [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))] - [ActiveIssue("https://github.com/dotnet/runtime/issues/34023", TestRuntimes.Mono)] + [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported), nameof(PlatformDetection.IsPreciseGcSupported))] public async Task Factory_CleanupCycle_DisposesEligibleHandler() { // Arrange @@ -412,8 +411,7 @@ namespace Microsoft.Extensions.Http return cleanupEntry; } - [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/34023", TestRuntimes.Mono)] + [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsPreciseGcSupported))] public async Task Factory_CleanupCycle_DisposesLiveHandler() { // Arrange -- 2.7.4