From 4ecf25545c3b34eb5a74ce920e421e59aab94905 Mon Sep 17 00:00:00 2001 From: Hideto Ueno Date: Thu, 12 Dec 2019 13:42:40 +0000 Subject: [PATCH] [Attributor][NFC] Fix comments and unnecessary comma --- llvm/include/llvm/Transforms/IPO/Attributor.h | 4 +++- llvm/lib/Transforms/IPO/Attributor.cpp | 13 +++++++------ 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/llvm/include/llvm/Transforms/IPO/Attributor.h b/llvm/include/llvm/Transforms/IPO/Attributor.h index 4f6f823..bacbccd 100644 --- a/llvm/include/llvm/Transforms/IPO/Attributor.h +++ b/llvm/include/llvm/Transforms/IPO/Attributor.h @@ -1840,7 +1840,9 @@ struct DerefState : AbstractState { /// ``` /// In that case, AccessedBytesMap is `{0:4, 4:4, 8:4, 40:4}`. /// AccessedBytesMap is std::map so it is iterated in accending order on - /// key(Offset). So KnownBytes will be updated like this: |Access | KnownBytes + /// key(Offset). So KnownBytes will be updated like this: + /// + /// |Access | KnownBytes /// |(0, 4)| 0 -> 4 /// |(4, 4)| 4 -> 8 /// |(8, 4)| 8 -> 12 diff --git a/llvm/lib/Transforms/IPO/Attributor.cpp b/llvm/lib/Transforms/IPO/Attributor.cpp index f43c02c..305cc28 100644 --- a/llvm/lib/Transforms/IPO/Attributor.cpp +++ b/llvm/lib/Transforms/IPO/Attributor.cpp @@ -1564,7 +1564,7 @@ struct AANoFreeFloating : AANoFreeImpl { isa(UserI) || isa(UserI)) { Follow = true; return true; - }; + } // Unknown user. return false; @@ -3254,7 +3254,8 @@ struct AAAlignImpl : AAAlign { bool followUse(Attributor &A, const Use *U, const Instruction *I) { bool TrackUse = false; - unsigned int KnownAlign = getKnownAlignForUse(A, *this, getAssociatedValue(), U, I, TrackUse); + unsigned int KnownAlign = + getKnownAlignForUse(A, *this, getAssociatedValue(), U, I, TrackUse); takeKnownMaximum(KnownAlign); return TrackUse; @@ -3950,14 +3951,14 @@ struct AAValueSimplifyArgument final : AAValueSimplifyImpl { // callback calls). Value *ArgOp = ACS.getCallArgOperand(getArgNo()); if (!ArgOp) - return false; + return false; // We can only propagate thread independent values through callbacks. // This is different to direct/indirect call sites because for them we // know the thread executing the caller and callee is the same. For // callbacks this is not guaranteed, thus a thread dependent value could // be different for the caller and callee, making it invalid to propagate. if (ACS.isCallbackCall()) - if (auto *C =dyn_cast(ArgOp)) + if (auto *C = dyn_cast(ArgOp)) if (C->isThreadDependent()) return false; return checkAndUpdate(A, *this, *ArgOp, SimplifiedAssociatedValue); @@ -5558,8 +5559,8 @@ void Attributor::identifyDefaultAbstractAttributes(Function &F) { // Call site argument attribute "align". getOrCreateAAFor(CSArgPos); - // Call site argument attribute "nofree". - getOrCreateAAFor(CSArgPos); + // Call site argument attribute "nofree". + getOrCreateAAFor(CSArgPos); } } return true; -- 2.7.4