From 4e271c947ceea386e59ad99d4ba70cd4fb0bba08 Mon Sep 17 00:00:00 2001 From: Peter Collingbourne Date: Mon, 24 Oct 2016 20:15:39 +0000 Subject: [PATCH] scripts: Document existing problems with the symbolizer build script. Reviewers: eugenis, vitalybuka Subscribers: llvm-commits, kubabrecka Differential Revision: https://reviews.llvm.org/D25846 llvm-svn: 285013 --- .../lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/compiler-rt/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh b/compiler-rt/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh index ecfcb21..07239eb 100755 --- a/compiler-rt/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh +++ b/compiler-rt/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh @@ -18,6 +18,12 @@ # # The script will modify the output directory which is given as the first # argument to the script. +# +# FIXME: We should really be using a simpler approach to building this object +# file, and it should be available as a regular cmake rule. Conceptually, we +# want to be doing "ld -r" followed by "objcopy -G" to create a relocatable +# object file with only our entry points exposed. However, this does not work at +# present, see PR30750. SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)" SRC_DIR=$(readlink -f $SCRIPT_DIR/..) -- 2.7.4