From 4de58e49fda65f19f3583549642ab23318fa4e42 Mon Sep 17 00:00:00 2001 From: "bmeurer@chromium.org" Date: Fri, 12 Sep 2014 08:50:38 +0000 Subject: [PATCH] [arm] Disable --turbo-types by default instead of ignoring the flag. R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/561913004 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23903 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/compiler.cc | 3 --- src/flag-definitions.h | 4 ++++ 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/compiler.cc b/src/compiler.cc index b89a645..58e135c 100644 --- a/src/compiler.cc +++ b/src/compiler.cc @@ -140,10 +140,7 @@ void CompilationInfo::Initialize(Isolate* isolate, if (isolate_->debug()->is_active()) MarkAsDebug(); if (FLAG_context_specialization) MarkAsContextSpecializing(); if (FLAG_turbo_inlining) MarkAsInliningEnabled(); -#if !V8_TARGET_ARCH_ARM && !V8_TARGET_ARCH_ARM64 && V8_TURBOFAN_BACKEND - // TODO(mstarzinger): Bugs in ARM back-end block enabling typed pipeline. if (FLAG_turbo_types) MarkAsTypingEnabled(); -#endif if (!shared_info_.is_null()) { DCHECK(strict_mode() == SLOPPY); diff --git a/src/flag-definitions.h b/src/flag-definitions.h index 78837fe..12e33a2 100644 --- a/src/flag-definitions.h +++ b/src/flag-definitions.h @@ -333,7 +333,11 @@ DEFINE_BOOL(trace_turbo_types, true, "trace generated TurboFan types") DEFINE_BOOL(trace_turbo_scheduler, false, "trace generated TurboFan scheduler") DEFINE_BOOL(turbo_verify, false, "verify TurboFan graphs at each phase") DEFINE_BOOL(turbo_stats, false, "print TurboFan statistics") +#if !V8_TARGET_ARCH_ARM && !V8_TARGET_ARCH_ARM64 && V8_TURBOFAN_BACKEND DEFINE_BOOL(turbo_types, true, "use typed lowering in TurboFan") +#else +DEFINE_BOOL(turbo_types, false, "use typed lowering in TurboFan") +#endif DEFINE_BOOL(turbo_source_positions, false, "track source code positions when building TurboFan IR") DEFINE_BOOL(context_specialization, false, -- 2.7.4