From 4d6b3a54adf76ac51928ce43836a2b9478aed636 Mon Sep 17 00:00:00 2001 From: "ager@chromium.org" Date: Thu, 19 Mar 2009 19:29:23 +0000 Subject: [PATCH] Fix lint. TBR=iposva Review URL: http://codereview.chromium.org/50026 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1551 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/factory.h | 2 +- src/heap.cc | 2 +- src/heap.h | 4 ++-- src/objects.cc | 2 +- test/cctest/test-api.cc | 8 ++++---- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/factory.h b/src/factory.h index f014ba5..2564c3c 100644 --- a/src/factory.h +++ b/src/factory.h @@ -299,7 +299,7 @@ class Factory : public AllStatic { static Handle name() { return Handle(&Heap::name##_); } SYMBOL_LIST(SYMBOL_ACCESSOR) #undef SYMBOL_ACCESSOR - + static Handle hidden_symbol() { return Handle(&Heap::hidden_symbol_); } diff --git a/src/heap.cc b/src/heap.cc index ce60ace..8bab00e 100644 --- a/src/heap.cc +++ b/src/heap.cc @@ -1204,7 +1204,7 @@ bool Heap::CreateInitialObjects() { (name##_) = String::cast(obj); SYMBOL_LIST(SYMBOL_INITIALIZE) #undef SYMBOL_INITIALIZE - + // Allocate the hidden symbol which is used to identify the hidden properties // in JSObjects. The hash code has a special value so that it will not match // the empty string when searching for the property. It cannot be part of the diff --git a/src/heap.h b/src/heap.h index f8b104a..9b5085d 100644 --- a/src/heap.h +++ b/src/heap.h @@ -644,7 +644,7 @@ class Heap : public AllStatic { #define SYMBOL_ACCESSOR(name, str) static String* name() { return name##_; } SYMBOL_LIST(SYMBOL_ACCESSOR) #undef SYMBOL_ACCESSOR - + // The hidden_symbol is special because it is the empty string, but does // not match the empty string. static String* hidden_symbol() { return hidden_symbol_; } @@ -891,7 +891,7 @@ class Heap : public AllStatic { #define SYMBOL_DECLARATION(name, str) static String* name##_; SYMBOL_LIST(SYMBOL_DECLARATION) #undef SYMBOL_DECLARATION - + // The special hidden symbol which is an empty string, but does not match // any string when looked up in properties. static String* hidden_symbol_; diff --git a/src/objects.cc b/src/objects.cc index 3847e6c..72fc5e5 100644 --- a/src/objects.cc +++ b/src/objects.cc @@ -5145,7 +5145,7 @@ Object* JSObject::GetHiddenProperties(bool create_if_needed) { #ifdef DEBUG PropertyDetails details(descriptors->GetDetails(0)); ASSERT(details.type() == FIELD); -#endif // DEBUG +#endif // DEBUG Object* value = descriptors->GetValue(0); return FastPropertyAt(Descriptor::IndexFromValue(value)); } diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc index 882db05..71f2493 100644 --- a/test/cctest/test-api.cc +++ b/test/cctest/test-api.cc @@ -1290,14 +1290,14 @@ THREADED_TEST(HiddenProperties) { v8::Local key = v8_str("api-test::hidden-key"); v8::Local empty = v8_str(""); v8::Local prop_name = v8_str("prop_name"); - + i::Heap::CollectAllGarbage(); CHECK(obj->SetHiddenValue(key, v8::Integer::New(1503))); CHECK_EQ(1503, obj->GetHiddenValue(key)->Int32Value()); CHECK(obj->SetHiddenValue(key, v8::Integer::New(2002))); CHECK_EQ(2002, obj->GetHiddenValue(key)->Int32Value()); - + i::Heap::CollectAllGarbage(); // Make sure we do not find the hidden property. @@ -1308,7 +1308,7 @@ THREADED_TEST(HiddenProperties) { CHECK(obj->Set(empty, v8::Integer::New(2003))); CHECK_EQ(2002, obj->GetHiddenValue(key)->Int32Value()); CHECK_EQ(2003, obj->Get(empty)->Int32Value()); - + i::Heap::CollectAllGarbage(); // Add another property and delete it afterwards to force the object in @@ -1319,7 +1319,7 @@ THREADED_TEST(HiddenProperties) { CHECK_EQ(2002, obj->GetHiddenValue(key)->Int32Value()); CHECK(obj->Delete(prop_name)); CHECK_EQ(2002, obj->GetHiddenValue(key)->Int32Value()); - + i::Heap::CollectAllGarbage(); CHECK(obj->DeleteHiddenValue(key)); -- 2.7.4