From 4cf6a6e086572ae1debf865f8fc645e10737b7be Mon Sep 17 00:00:00 2001 From: Sebastian Rasmussen Date: Wed, 6 Aug 2014 12:34:42 +0200 Subject: [PATCH] tests: Add missing unrefs of objects after use Unreffing the objects returned by gst_bin_get_by_name() and gst_pipeline_get_use() were missing in several tests, so add these. Fixes https://bugzilla.gnome.org/show_bug.cgi?id=734345 --- docs/manual/appendix-programs.xml | 1 + tests/check/gst/gstbin.c | 2 ++ tests/check/pipelines/parse-launch.c | 1 + tests/examples/launch/mp3parselaunch.c | 1 + 4 files changed, 5 insertions(+) diff --git a/docs/manual/appendix-programs.xml b/docs/manual/appendix-programs.xml index b888a17..72eab54 100644 --- a/docs/manual/appendix-programs.xml +++ b/docs/manual/appendix-programs.xml @@ -59,6 +59,7 @@ main (int argc, char *argv[]) filesrc = gst_bin_get_by_name (GST_BIN (pipeline), "my_filesrc"); g_object_set (filesrc, "location", argv[1], NULL); + g_object_unref (filesrc); gst_element_set_state (pipeline, GST_STATE_PLAYING); diff --git a/tests/check/gst/gstbin.c b/tests/check/gst/gstbin.c index 58c91ea..409e273 100644 --- a/tests/check/gst/gstbin.c +++ b/tests/check/gst/gstbin.c @@ -201,6 +201,7 @@ GST_START_TEST (test_eos) gst_pad_set_active (pad2, FALSE); gst_check_teardown_src_pad (sink1); gst_check_teardown_src_pad (sink2); + gst_object_unref (bus); gst_object_unref (pipeline); } @@ -259,6 +260,7 @@ GST_START_TEST (test_stream_start) gst_pad_set_active (pad2, FALSE); gst_check_teardown_src_pad (sink1); gst_check_teardown_src_pad (sink2); + gst_object_unref (bus); gst_object_unref (pipeline); } diff --git a/tests/check/pipelines/parse-launch.c b/tests/check/pipelines/parse-launch.c index 8b6a6bc..78a2ba4 100644 --- a/tests/check/pipelines/parse-launch.c +++ b/tests/check/pipelines/parse-launch.c @@ -467,6 +467,7 @@ run_delayed_test (const gchar * pipe_str, const gchar * peer, fail_if (peer_elem == NULL, "Could not retrieve peer %s", peer); sinkpad = gst_element_get_static_pad (peer_elem, "sink"); + gst_object_unref (peer_elem); fail_if (sinkpad == NULL, "Peer element did not have a 'sink' pad"); fail_unless (peerpad == sinkpad, diff --git a/tests/examples/launch/mp3parselaunch.c b/tests/examples/launch/mp3parselaunch.c index cc00a07..e77c1bd 100644 --- a/tests/examples/launch/mp3parselaunch.c +++ b/tests/examples/launch/mp3parselaunch.c @@ -72,6 +72,7 @@ main (int argc, char *argv[]) filesrc = gst_bin_get_by_name (GST_BIN (bin), "my_filesrc"); g_object_set (G_OBJECT (filesrc), "location", argv[1], NULL); + gst_object_unref (filesrc); /* start playing */ gst_element_set_state (bin, GST_STATE_PLAYING); -- 2.7.4