From 4cc87a76591e7712ee729bc3b4eaeb8c08a0a245 Mon Sep 17 00:00:00 2001 From: Seunghun Lee Date: Wed, 13 Nov 2019 18:15:51 +0900 Subject: [PATCH] e_info_server: fix a coverity issue not checking return of tbm_surface_map. Change-Id: I9005d9e25de04689b61d2984c94a30544892b85f --- src/bin/e_info_server.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/bin/e_info_server.c b/src/bin/e_info_server.c index a007bd6ceb..81937b60f5 100644 --- a/src/bin/e_info_server.c +++ b/src/bin/e_info_server.c @@ -6525,6 +6525,7 @@ e_info_server_dump_client(E_Client *ec, char *fname) int w = 0, h = 0; Ecore_Evas *ee = NULL; Evas_Object *img = NULL; + int res; if (!ec) return; if (e_client_util_ignored_get(ec)) return; @@ -6550,7 +6551,9 @@ e_info_server_dump_client(E_Client *ec, char *fname) EINA_SAFETY_ON_NULL_RETURN(tbm_surface); memset(&surface_info, 0, sizeof(tbm_surface_info_s)); - tbm_surface_map(tbm_surface, TBM_SURF_OPTION_READ, &surface_info); + res = tbm_surface_map(tbm_surface, TBM_SURF_OPTION_READ, &surface_info); + if (res != TBM_SURFACE_ERROR_NONE) + return; data = surface_info.planes[0].ptr; w = surface_info.planes[0].stride / 4; @@ -6563,7 +6566,9 @@ e_info_server_dump_client(E_Client *ec, char *fname) EINA_SAFETY_ON_NULL_RETURN(tbm_surface); memset(&surface_info, 0, sizeof(tbm_surface_info_s)); - tbm_surface_map(tbm_surface, TBM_SURF_OPTION_READ, &surface_info); + res = tbm_surface_map(tbm_surface, TBM_SURF_OPTION_READ, &surface_info); + if (res != TBM_SURFACE_ERROR_NONE) + return; data = surface_info.planes[0].ptr; w = surface_info.planes[0].stride / 4; -- 2.34.1