From 4c9e848275b2073db55ebc1b7c18a52ab32954eb Mon Sep 17 00:00:00 2001 From: Doug Evans Date: Sun, 23 Nov 2014 20:30:34 -0800 Subject: [PATCH] Fix dumping of function arguments. gdb/ChangeLog: * gdbtypes.c (print_args): Renamed from print_arg_types. Print arg number and name if present. All callers updated. (dump_fn_fieldlists): Fix indentation of args. --- gdb/ChangeLog | 6 ++++++ gdb/gdbtypes.c | 16 +++++++++------- 2 files changed, 15 insertions(+), 7 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 07dacc0..a5881bf 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2014-11-23 Doug Evans + + * gdbtypes.c (print_args): Renamed from print_arg_types. Print arg + number and name if present. All callers updated. + (dump_fn_fieldlists): Fix indentation of args. + 2014-11-23 Patrick Palka * MAINTAINERS (Write After Approval): Add myself. diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c index b921c64..976d56f 100644 --- a/gdb/gdbtypes.c +++ b/gdb/gdbtypes.c @@ -3509,14 +3509,18 @@ print_bit_vector (B_TYPE *bits, int nbits) situation. */ static void -print_arg_types (struct field *args, int nargs, int spaces) +print_args (struct field *args, int nargs, int spaces) { if (args != NULL) { int i; for (i = 0; i < nargs; i++) - recursive_dump_type (args[i].type, spaces + 2); + { + printfi_filtered (spaces, "[%d] name '%s'\n", i, + args[i].name != NULL ? args[i].name : ""); + recursive_dump_type (args[i].type, spaces + 2); + } } } @@ -3574,11 +3578,9 @@ dump_fn_fieldlists (struct type *type, int spaces) gdb_print_host_address (TYPE_FN_FIELD_ARGS (f, overload_idx), gdb_stdout); printf_filtered ("\n"); - - print_arg_types (TYPE_FN_FIELD_ARGS (f, overload_idx), - TYPE_NFIELDS (TYPE_FN_FIELD_TYPE (f, - overload_idx)), - spaces); + print_args (TYPE_FN_FIELD_ARGS (f, overload_idx), + TYPE_NFIELDS (TYPE_FN_FIELD_TYPE (f, overload_idx)), + spaces + 8 + 2); printfi_filtered (spaces + 8, "fcontext "); gdb_print_host_address (TYPE_FN_FIELD_FCONTEXT (f, overload_idx), gdb_stdout); -- 2.7.4