From 4c9db2045a50e9afcc8196d4269d3092cb72d0c4 Mon Sep 17 00:00:00 2001 From: Simon Pilgrim Date: Fri, 7 Jun 2019 18:07:06 +0000 Subject: [PATCH] [DAGCombine] Use APInt::extractBits in "sub-splat" constant mask detection. NFCI. llvm-svn: 362820 --- llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp b/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp index f78f775..696de2c 100644 --- a/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp +++ b/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp @@ -5005,10 +5005,10 @@ SDValue DAGCombiner::visitAND(SDNode *N) { // Make sure that variable 'Constant' is only set if 'SplatBitSize' is a // multiple of 'BitWidth'. Otherwise, we could propagate a wrong value. - if (SplatBitSize % BitWidth == 0) { + if ((SplatBitSize % BitWidth) == 0) { Constant = APInt::getAllOnesValue(BitWidth); - for (unsigned i = 0, n = SplatBitSize/BitWidth; i < n; ++i) - Constant &= SplatValue.lshr(i*BitWidth).zextOrTrunc(BitWidth); + for (unsigned i = 0, n = (SplatBitSize / BitWidth); i < n; ++i) + Constant &= SplatValue.extractBits(BitWidth, i * BitWidth); } } } -- 2.7.4