From 4c82a4c262c53efaad8d0110914e6e874eb46860 Mon Sep 17 00:00:00 2001 From: Juerg Billeter Date: Fri, 21 Mar 2008 19:07:42 +0000 Subject: [PATCH] report error when trying to declare private construct properties, patch by 2008-03-21 Juerg Billeter * vala/valasemanticanalyzer.vala: report error when trying to declare private construct properties, patch by Daniel Silverstone, fixes bug 522685 svn path=/trunk/; revision=1146 --- ChangeLog | 6 ++++++ vala/valasemanticanalyzer.vala | 8 ++++++++ 2 files changed, 14 insertions(+) diff --git a/ChangeLog b/ChangeLog index 31d3951..776430a 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,11 @@ 2008-03-21 Jürg Billeter + * vala/valasemanticanalyzer.vala: report error when trying to + declare private construct properties, + patch by Daniel Silverstone, fixes bug 522685 + +2008-03-21 Jürg Billeter + * vala/valaenum.vala, vala/valaenumvalue.vala, vala/valainterfacewriter.vala, gobject/valaccodegenerator.vala, gobject/valaccodegeneratorinterface.vala, diff --git a/vala/valasemanticanalyzer.vala b/vala/valasemanticanalyzer.vala index c868d51..257ea83 100644 --- a/vala/valasemanticanalyzer.vala +++ b/vala/valasemanticanalyzer.vala @@ -629,6 +629,14 @@ public class Vala.SemanticAnalyzer : CodeVisitor { } } } + + /* construct properties must be public */ + if (prop.set_accessor != null && prop.set_accessor.construction) { + if (prop.access != SymbolAccessibility.PUBLIC) { + prop.error = true; + Report.error (prop.source_reference, "%s: construct properties must be public".printf (prop.get_full_name ())); + } + } } public override void visit_property_accessor (PropertyAccessor! acc) { -- 2.7.4