From 4c46d629379fa223e06d8de014d0378841c42eb1 Mon Sep 17 00:00:00 2001 From: Jihoon Lee Date: Fri, 14 Jan 2022 00:22:29 +0900 Subject: [PATCH] [Fix] change max order to point last This patch fixes bug that gradient clipping was not applied correctly when optimization is on. **Self evaluation:** 1. Build test: [X]Passed [ ]Failed [ ]Skipped 2. Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: Jihoon Lee --- nntrainer/graph/network_graph.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/nntrainer/graph/network_graph.cpp b/nntrainer/graph/network_graph.cpp index 911efec..a2f90ab 100644 --- a/nntrainer/graph/network_graph.cpp +++ b/nntrainer/graph/network_graph.cpp @@ -411,8 +411,11 @@ void NetworkGraph::setMaxExecutionOrder(bool skip_optimize) { std::max(max_exec_order, std::get<1>(ln->getExecutionOrder())); #endif } else { + /// FIXME below code need explanation + // max_exec_order = + // std::max(max_exec_order, std::get<0>(ln->getExecutionOrder())); max_exec_order = - std::max(max_exec_order, std::get<0>(ln->getExecutionOrder())); + std::max(max_exec_order, std::get<2>(ln->getExecutionOrder())); } } } -- 2.7.4