From 4c0d2f01112a814a8d62494b138859e64a701570 Mon Sep 17 00:00:00 2001
From: "dotnet-maestro[bot]"
<42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date: Mon, 14 Jun 2021 13:02:05 +0000
Subject: [PATCH] [main] Update dependencies from mono/linker dotnet/runtime
dotnet/arcade dnceng/internal/dotnet-optimization dotnet/xharness
dotnet/hotreload-utils (#54060)
[main] Update dependencies from mono/linker dotnet/runtime dotnet/arcade dnceng/internal/dotnet-optimization dotnet/xharness dotnet/hotreload-utils
---
.config/dotnet-tools.json | 2 +-
eng/Version.Details.xml | 124 +++++++++++++++----------------
eng/Versions.props | 52 ++++++-------
eng/common/dotnet-install.sh | 2 +-
eng/common/internal-feed-operations.ps1 | 6 +-
eng/common/internal-feed-operations.sh | 2 +-
eng/common/sdk-task.ps1 | 4 +-
eng/common/sdl/execute-all-sdl-tools.ps1 | 2 +-
eng/common/sdl/init-sdl.ps1 | 2 +-
eng/common/sdl/run-sdl.ps1 | 2 +-
eng/common/templates/job/onelocbuild.yml | 8 ++
eng/common/tools.ps1 | 99 ++++++++++++------------
eng/common/tools.sh | 9 ++-
global.json | 10 +--
14 files changed, 163 insertions(+), 161 deletions(-)
diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index b7d3016..02e0543 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -15,7 +15,7 @@
]
},
"microsoft.dotnet.xharness.cli": {
- "version": "1.0.0-prerelease.21307.1",
+ "version": "1.0.0-prerelease.21314.1",
"commands": [
"xharness"
]
diff --git a/eng/Version.Details.xml b/eng/Version.Details.xml
index aa14dcb..2e73128 100644
--- a/eng/Version.Details.xml
+++ b/eng/Version.Details.xml
@@ -6,69 +6,69 @@
-
+
https://github.com/dotnet/arcade
- 85a65ea1fca1d0867f699fed44d191358270bf6a
+ 4a2b475948d498b89fedef7cf890883f49bc1ea3
-
+
https://github.com/dotnet/arcade
- 85a65ea1fca1d0867f699fed44d191358270bf6a
+ 4a2b475948d498b89fedef7cf890883f49bc1ea3
-
+
https://github.com/dotnet/arcade
- 85a65ea1fca1d0867f699fed44d191358270bf6a
+ 4a2b475948d498b89fedef7cf890883f49bc1ea3
-
+
https://github.com/dotnet/arcade
- 85a65ea1fca1d0867f699fed44d191358270bf6a
+ 4a2b475948d498b89fedef7cf890883f49bc1ea3
-
+
https://github.com/dotnet/arcade
- 85a65ea1fca1d0867f699fed44d191358270bf6a
+ 4a2b475948d498b89fedef7cf890883f49bc1ea3
-
+
https://github.com/dotnet/arcade
- 85a65ea1fca1d0867f699fed44d191358270bf6a
+ 4a2b475948d498b89fedef7cf890883f49bc1ea3
-
+
https://github.com/dotnet/arcade
- 85a65ea1fca1d0867f699fed44d191358270bf6a
+ 4a2b475948d498b89fedef7cf890883f49bc1ea3
-
+
https://github.com/dotnet/arcade
- 85a65ea1fca1d0867f699fed44d191358270bf6a
+ 4a2b475948d498b89fedef7cf890883f49bc1ea3
-
+
https://github.com/dotnet/arcade
- 85a65ea1fca1d0867f699fed44d191358270bf6a
+ 4a2b475948d498b89fedef7cf890883f49bc1ea3
-
+
https://github.com/dotnet/arcade
- 85a65ea1fca1d0867f699fed44d191358270bf6a
+ 4a2b475948d498b89fedef7cf890883f49bc1ea3
-
+
https://github.com/dotnet/arcade
- 85a65ea1fca1d0867f699fed44d191358270bf6a
+ 4a2b475948d498b89fedef7cf890883f49bc1ea3
-
+
https://github.com/dotnet/arcade
- 85a65ea1fca1d0867f699fed44d191358270bf6a
+ 4a2b475948d498b89fedef7cf890883f49bc1ea3
-
+
https://github.com/dotnet/arcade
- 85a65ea1fca1d0867f699fed44d191358270bf6a
+ 4a2b475948d498b89fedef7cf890883f49bc1ea3
-
+
https://github.com/dotnet/arcade
- 85a65ea1fca1d0867f699fed44d191358270bf6a
+ 4a2b475948d498b89fedef7cf890883f49bc1ea3
-
+
https://github.com/dotnet/arcade
- 85a65ea1fca1d0867f699fed44d191358270bf6a
+ 4a2b475948d498b89fedef7cf890883f49bc1ea3
-
+
https://github.com/dotnet/arcade
- 85a65ea1fca1d0867f699fed44d191358270bf6a
+ 4a2b475948d498b89fedef7cf890883f49bc1ea3
https://github.com/microsoft/vstest
@@ -146,73 +146,73 @@
https://github.com/dotnet/runtime
38017c3935de95d0335bac04f4901ddfc2718656
-
+
https://github.com/dotnet/runtime
- 1d2aa13ffc256a8c3f645de9c4d0f1d4f3296711
+ af5c238556e204583b129cc8f5c7338f84dc2c40
-
+
https://github.com/dotnet/runtime
- 1d2aa13ffc256a8c3f645de9c4d0f1d4f3296711
+ af5c238556e204583b129cc8f5c7338f84dc2c40
-
+
https://github.com/dotnet/runtime
- 1d2aa13ffc256a8c3f645de9c4d0f1d4f3296711
+ af5c238556e204583b129cc8f5c7338f84dc2c40
-
+
https://github.com/dotnet/runtime
- 1d2aa13ffc256a8c3f645de9c4d0f1d4f3296711
+ af5c238556e204583b129cc8f5c7338f84dc2c40
-
+
https://github.com/dotnet/runtime
- 1d2aa13ffc256a8c3f645de9c4d0f1d4f3296711
+ af5c238556e204583b129cc8f5c7338f84dc2c40
-
+
https://github.com/dotnet/runtime
- 1d2aa13ffc256a8c3f645de9c4d0f1d4f3296711
+ af5c238556e204583b129cc8f5c7338f84dc2c40
-
+
https://github.com/dotnet/runtime
- 1d2aa13ffc256a8c3f645de9c4d0f1d4f3296711
+ af5c238556e204583b129cc8f5c7338f84dc2c40
https://github.com/mono/linker
caeaf2a3fb3f636805fdd4881df4f9a539fff8f6
-
+
https://github.com/dotnet/xharness
- 2751a33949055a45fd79e2ae126f127daf1aee44
+ d6f8a4ad30908fb210390380eae97264e4fbe8ce
-
+
https://github.com/dotnet/xharness
- 2751a33949055a45fd79e2ae126f127daf1aee44
+ d6f8a4ad30908fb210390380eae97264e4fbe8ce
-
+
https://github.com/dotnet/arcade
- 85a65ea1fca1d0867f699fed44d191358270bf6a
+ 4a2b475948d498b89fedef7cf890883f49bc1ea3
-
+
https://dev.azure.com/dnceng/internal/_git/dotnet-optimization
- 6d1aebccb1ae6c3562bb0cceba8464f78b4e1afd
+ 4e5bea15eb5a9c8cf9142195b1c9c78437a5b27f
-
+
https://dev.azure.com/dnceng/internal/_git/dotnet-optimization
- 6d1aebccb1ae6c3562bb0cceba8464f78b4e1afd
+ 4e5bea15eb5a9c8cf9142195b1c9c78437a5b27f
-
+
https://dev.azure.com/dnceng/internal/_git/dotnet-optimization
- 6d1aebccb1ae6c3562bb0cceba8464f78b4e1afd
+ 4e5bea15eb5a9c8cf9142195b1c9c78437a5b27f
-
+
https://dev.azure.com/dnceng/internal/_git/dotnet-optimization
- 6d1aebccb1ae6c3562bb0cceba8464f78b4e1afd
+ 4e5bea15eb5a9c8cf9142195b1c9c78437a5b27f
https://github.com/dotnet/emsdk
defa37b05c734e025292c5747664e970cd2ac444
-
+
https://github.com/dotnet/hotreload-utils
- 04541efa21e114256a1ca9ca4a14685fd9f7e48e
+ 25b814e010cd4796cedfbcce72a274c26928f496
diff --git a/eng/Versions.props b/eng/Versions.props
index 693c68e..7c4e7f2 100644
--- a/eng/Versions.props
+++ b/eng/Versions.props
@@ -49,28 +49,28 @@
3.10.0-2.final
3.10.0-2.final
- 6.0.0-beta.21304.1
- 6.0.0-beta.21304.1
- 6.0.0-beta.21304.1
- 6.0.0-beta.21304.1
- 6.0.0-beta.21304.1
- 6.0.0-beta.21304.1
- 2.5.1-beta.21304.1
- 6.0.0-beta.21304.1
- 6.0.0-beta.21304.1
- 6.0.0-beta.21304.1
- 6.0.0-beta.21304.1
- 6.0.0-beta.21304.1
- 6.0.0-beta.21304.1
+ 6.0.0-beta.21311.3
+ 6.0.0-beta.21311.3
+ 6.0.0-beta.21311.3
+ 6.0.0-beta.21311.3
+ 6.0.0-beta.21311.3
+ 6.0.0-beta.21311.3
+ 2.5.1-beta.21311.3
+ 6.0.0-beta.21311.3
+ 6.0.0-beta.21311.3
+ 6.0.0-beta.21311.3
+ 6.0.0-beta.21311.3
+ 6.0.0-beta.21311.3
+ 6.0.0-beta.21311.3
5.9.0-preview.2
6.0.0-alpha.1.20612.4
- 6.0.0-preview.6.21307.1
- 6.0.0-preview.6.21307.1
+ 6.0.0-preview.6.21314.1
+ 6.0.0-preview.6.21314.1
3.1.0
- 6.0.0-preview.6.21307.1
+ 6.0.0-preview.6.21314.1
1.2.0-beta.304
4.3.0
@@ -100,14 +100,14 @@
4.3.1
4.7.0
4.7.0
- 6.0.0-preview.6.21307.1
- 6.0.0-preview.6.21307.1
+ 6.0.0-preview.6.21314.1
+ 6.0.0-preview.6.21314.1
4.3.0
4.5.4
4.5.0
1.1.1
4.3.0
- 6.0.0-preview.6.21307.1
+ 6.0.0-preview.6.21314.1
6.0.0-beta.21307.1
6.0.0-beta.21307.1
@@ -119,10 +119,10 @@
6.0.0-beta.21307.1
6.0.0-beta.21307.1
- 1.0.0-prerelease.21308.4
- 1.0.0-prerelease.21308.4
- 1.0.0-prerelease.21308.4
- 1.0.0-prerelease.21308.4
+ 1.0.0-prerelease.21313.4
+ 1.0.0-prerelease.21313.4
+ 1.0.0-prerelease.21313.4
+ 1.0.0-prerelease.21313.4
16.9.0-beta1.21055.5
2.0.0-beta1.20253.1
@@ -146,9 +146,9 @@
1.0.1-prerelease-00006
16.9.0-preview-20201201-01
- 1.0.0-prerelease.21307.1
- 1.0.0-prerelease.21307.1
- 1.0.1-alpha.0.21307.1
+ 1.0.0-prerelease.21314.1
+ 1.0.0-prerelease.21314.1
+ 1.0.1-alpha.0.21311.1
2.4.1
2.4.2
1.3.0
diff --git a/eng/common/dotnet-install.sh b/eng/common/dotnet-install.sh
index d6efeb4..fdfeea6 100755
--- a/eng/common/dotnet-install.sh
+++ b/eng/common/dotnet-install.sh
@@ -70,7 +70,7 @@ case $cpuname in
;;
esac
-dotnetRoot="$repo_root/.dotnet"
+dotnetRoot="${repo_root}.dotnet"
if [[ $architecture != "" ]] && [[ $architecture != $buildarch ]]; then
dotnetRoot="$dotnetRoot/$architecture"
fi
diff --git a/eng/common/internal-feed-operations.ps1 b/eng/common/internal-feed-operations.ps1
index 418c099..92b7734 100644
--- a/eng/common/internal-feed-operations.ps1
+++ b/eng/common/internal-feed-operations.ps1
@@ -45,11 +45,11 @@ function SetupCredProvider {
# Then, we set the 'VSS_NUGET_EXTERNAL_FEED_ENDPOINTS' environment variable to restore from the stable
# feeds successfully
- $nugetConfigPath = "$RepoRoot\NuGet.config"
+ $nugetConfigPath = Join-Path $RepoRoot "NuGet.config"
if (-Not (Test-Path -Path $nugetConfigPath)) {
Write-PipelineTelemetryError -Category 'Build' -Message 'NuGet.config file not found in repo root!'
- ExitWithExitCode 1
+ ExitWithExitCode 1
}
$endpoints = New-Object System.Collections.ArrayList
@@ -85,7 +85,7 @@ function SetupCredProvider {
#Workaround for https://github.com/microsoft/msbuild/issues/4430
function InstallDotNetSdkAndRestoreArcade {
- $dotnetTempDir = "$RepoRoot\dotnet"
+ $dotnetTempDir = Join-Path $RepoRoot "dotnet"
$dotnetSdkVersion="2.1.507" # After experimentation we know this version works when restoring the SDK (compared to 3.0.*)
$dotnet = "$dotnetTempDir\dotnet.exe"
$restoreProjPath = "$PSScriptRoot\restore.proj"
diff --git a/eng/common/internal-feed-operations.sh b/eng/common/internal-feed-operations.sh
index e2233e7..9378223 100755
--- a/eng/common/internal-feed-operations.sh
+++ b/eng/common/internal-feed-operations.sh
@@ -39,7 +39,7 @@ function SetupCredProvider {
# Then, we set the 'VSS_NUGET_EXTERNAL_FEED_ENDPOINTS' environment variable to restore from the stable
# feeds successfully
- local nugetConfigPath="$repo_root/NuGet.config"
+ local nugetConfigPath="{$repo_root}NuGet.config"
if [ ! "$nugetConfigPath" ]; then
Write-PipelineTelemetryError -category 'Build' "NuGet.config file not found in repo's root!"
diff --git a/eng/common/sdk-task.ps1 b/eng/common/sdk-task.ps1
index 65f1d75..b1bca63 100644
--- a/eng/common/sdk-task.ps1
+++ b/eng/common/sdk-task.ps1
@@ -34,7 +34,7 @@ function Print-Usage() {
function Build([string]$target) {
$logSuffix = if ($target -eq 'Execute') { '' } else { ".$target" }
$log = Join-Path $LogDir "$task$logSuffix.binlog"
- $outputPath = Join-Path $ToolsetDir "$task\\"
+ $outputPath = Join-Path $ToolsetDir "$task\"
MSBuild $taskProject `
/bl:$log `
@@ -64,7 +64,7 @@ try {
$GlobalJson.tools | Add-Member -Name "vs" -Value (ConvertFrom-Json "{ `"version`": `"16.5`" }") -MemberType NoteProperty
}
if( -not ($GlobalJson.tools.PSObject.Properties.Name -match "xcopy-msbuild" )) {
- $GlobalJson.tools | Add-Member -Name "xcopy-msbuild" -Value "16.8.0-preview3" -MemberType NoteProperty
+ $GlobalJson.tools | Add-Member -Name "xcopy-msbuild" -Value "16.10.0-preview2" -MemberType NoteProperty
}
if ($GlobalJson.tools."xcopy-msbuild".Trim() -ine "none") {
$xcopyMSBuildToolsFolder = InitializeXCopyMSBuild $GlobalJson.tools."xcopy-msbuild" -install $true
diff --git a/eng/common/sdl/execute-all-sdl-tools.ps1 b/eng/common/sdl/execute-all-sdl-tools.ps1
index 81b729f..2881a56 100644
--- a/eng/common/sdl/execute-all-sdl-tools.ps1
+++ b/eng/common/sdl/execute-all-sdl-tools.ps1
@@ -32,7 +32,7 @@ try {
$ErrorActionPreference = 'Stop'
Set-StrictMode -Version 2.0
$disableConfigureToolsetImport = $true
- $LASTEXITCODE = 0
+ $global:LASTEXITCODE = 0
# `tools.ps1` checks $ci to perform some actions. Since the SDL
# scripts don't necessarily execute in the same agent that run the
diff --git a/eng/common/sdl/init-sdl.ps1 b/eng/common/sdl/init-sdl.ps1
index 1fe9271..3ac1d92 100644
--- a/eng/common/sdl/init-sdl.ps1
+++ b/eng/common/sdl/init-sdl.ps1
@@ -10,7 +10,7 @@ Param(
$ErrorActionPreference = 'Stop'
Set-StrictMode -Version 2.0
$disableConfigureToolsetImport = $true
-$LASTEXITCODE = 0
+$global:LASTEXITCODE = 0
# `tools.ps1` checks $ci to perform some actions. Since the SDL
# scripts don't necessarily execute in the same agent that run the
diff --git a/eng/common/sdl/run-sdl.ps1 b/eng/common/sdl/run-sdl.ps1
index fe95ab3..3d9c87a 100644
--- a/eng/common/sdl/run-sdl.ps1
+++ b/eng/common/sdl/run-sdl.ps1
@@ -13,7 +13,7 @@ Param(
$ErrorActionPreference = 'Stop'
Set-StrictMode -Version 2.0
$disableConfigureToolsetImport = $true
-$LASTEXITCODE = 0
+$global:LASTEXITCODE = 0
try {
# `tools.ps1` checks $ci to perform some actions. Since the SDL
diff --git a/eng/common/templates/job/onelocbuild.yml b/eng/common/templates/job/onelocbuild.yml
index 2acdd52..e8bc77d 100644
--- a/eng/common/templates/job/onelocbuild.yml
+++ b/eng/common/templates/job/onelocbuild.yml
@@ -18,6 +18,9 @@ parameters:
LclSource: lclFilesInRepo
LclPackageId: ''
RepoType: gitHub
+ GitHubOrg: dotnet
+ MirrorRepo: ''
+ MirrorBranch: main
condition: ''
jobs:
@@ -66,6 +69,11 @@ jobs:
${{ if eq(parameters.RepoType, 'gitHub') }}:
repoType: ${{ parameters.RepoType }}
gitHubPatVariable: "${{ parameters.GithubPat }}"
+ ${{ if ne(parameters.MirrorRepo, '') }}:
+ isMirrorRepoSelected: true
+ gitHubOrganization: ${{ parameters.GitHubOrg }}
+ mirrorRepo: ${{ parameters.MirrorRepo }}
+ mirrorBranch: ${{ parameters.MirrorBranch }}
condition: ${{ parameters.condition }}
- task: PublishBuildArtifacts@1
diff --git a/eng/common/tools.ps1 b/eng/common/tools.ps1
index 2d8a74f..5619c7a 100644
--- a/eng/common/tools.ps1
+++ b/eng/common/tools.ps1
@@ -193,38 +193,42 @@ function InitializeDotNetCli([bool]$install, [bool]$createSdkLocationFile) {
return $global:_DotNetInstallDir = $dotnetRoot
}
+function Retry($downloadBlock, $maxRetries = 5) {
+ $retries = 1
+
+ while($true) {
+ try {
+ & $downloadBlock
+ break
+ }
+ catch {
+ Write-PipelineTelemetryError -Category 'InitializeToolset' -Message $_
+ }
+
+ if (++$retries -le $maxRetries) {
+ $delayInSeconds = [math]::Pow(2, $retries) - 1 # Exponential backoff
+ Write-Host "Retrying. Waiting for $delayInSeconds seconds before next attempt ($retries of $maxRetries)."
+ Start-Sleep -Seconds $delayInSeconds
+ }
+ else {
+ Write-PipelineTelemetryError -Category 'InitializeToolset' -Message "Unable to download file in $maxRetries attempts."
+ break
+ }
+
+ }
+}
+
function GetDotNetInstallScript([string] $dotnetRoot) {
$installScript = Join-Path $dotnetRoot 'dotnet-install.ps1'
if (!(Test-Path $installScript)) {
Create-Directory $dotnetRoot
$ProgressPreference = 'SilentlyContinue' # Don't display the console progress UI - it's a huge perf hit
-
- $maxRetries = 5
- $retries = 1
-
$uri = "https://dot.net/$dotnetInstallScriptVersion/dotnet-install.ps1"
- while($true) {
- try {
- Write-Host "GET $uri"
- Invoke-WebRequest $uri -OutFile $installScript
- break
- }
- catch {
- Write-Host "Failed to download '$uri'"
- Write-Error $_.Exception.Message -ErrorAction Continue
- }
-
- if (++$retries -le $maxRetries) {
- $delayInSeconds = [math]::Pow(2, $retries) - 1 # Exponential backoff
- Write-Host "Retrying. Waiting for $delayInSeconds seconds before next attempt ($retries of $maxRetries)."
- Start-Sleep -Seconds $delayInSeconds
- }
- else {
- throw "Unable to download file in $maxRetries attempts."
- }
-
- }
+ Retry({
+ Write-Host "GET $uri"
+ Invoke-WebRequest $uri -OutFile $installScript
+ })
}
return $installScript
@@ -308,8 +312,8 @@ function InitializeVisualStudioMSBuild([bool]$install, [object]$vsRequirements =
# If the version of msbuild is going to be xcopied,
# use this version. Version matches a package here:
- # https://dev.azure.com/dnceng/public/_packaging?_a=package&feed=dotnet-eng&package=RoslynTools.MSBuild&protocolType=NuGet&version=16.8.0-preview3&view=overview
- $defaultXCopyMSBuildVersion = '16.8.0-preview3'
+ # https://dev.azure.com/dnceng/public/_packaging?_a=package&feed=dotnet-eng&package=RoslynTools.MSBuild&protocolType=NuGet&version=16.10.0-preview2&view=overview
+ $defaultXCopyMSBuildVersion = '16.10.0-preview2'
if (!$vsRequirements) { $vsRequirements = $GlobalJson.tools.vs }
$vsMinVersionStr = if ($vsRequirements.version) { $vsRequirements.version } else { $vsMinVersionReqdStr }
@@ -403,9 +407,13 @@ function InitializeXCopyMSBuild([string]$packageVersion, [bool]$install) {
}
Create-Directory $packageDir
+
Write-Host "Downloading $packageName $packageVersion"
$ProgressPreference = 'SilentlyContinue' # Don't display the console progress UI - it's a huge perf hit
- Invoke-WebRequest "https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/flat2/$packageName/$packageVersion/$packageName.$packageVersion.nupkg" -OutFile $packagePath
+ Retry({
+ Invoke-WebRequest "https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/flat2/$packageName/$packageVersion/$packageName.$packageVersion.nupkg" -OutFile $packagePath
+ })
+
Unzip $packagePath $packageDir
}
@@ -442,27 +450,9 @@ function LocateVisualStudio([object]$vsRequirements = $null){
if (!(Test-Path $vsWhereExe)) {
Create-Directory $vsWhereDir
Write-Host 'Downloading vswhere'
- $maxRetries = 5
- $retries = 1
-
- while($true) {
- try {
- Invoke-WebRequest "https://netcorenativeassets.blob.core.windows.net/resource-packages/external/windows/vswhere/$vswhereVersion/vswhere.exe" -OutFile $vswhereExe
- break
- }
- catch{
- Write-PipelineTelemetryError -Category 'InitializeToolset' -Message $_
- }
-
- if (++$retries -le $maxRetries) {
- $delayInSeconds = [math]::Pow(2, $retries) - 1 # Exponential backoff
- Write-Host "Retrying. Waiting for $delayInSeconds seconds before next attempt ($retries of $maxRetries)."
- Start-Sleep -Seconds $delayInSeconds
- }
- else {
- Write-PipelineTelemetryError -Category 'InitializeToolset' -Message "Unable to download file in $maxRetries attempts."
- }
- }
+ Retry({
+ Invoke-WebRequest "https://netcorenativeassets.blob.core.windows.net/resource-packages/external/windows/vswhere/$vswhereVersion/vswhere.exe" -OutFile $vswhereExe
+ })
}
if (!$vsRequirements) { $vsRequirements = $GlobalJson.tools.vs }
@@ -498,7 +488,7 @@ function InitializeBuildTool() {
if (Test-Path variable:global:_BuildTool) {
# If the requested msbuild parameters do not match, clear the cached variables.
if($global:_BuildTool.Contains('ExcludePrereleaseVS') -and $global:_BuildTool.ExcludePrereleaseVS -ne $excludePrereleaseVS) {
- Remove-Item variable:global:_BuildTool
+ Remove-Item variable:global:_BuildTool
Remove-Item variable:global:_MSBuildExe
} else {
return $global:_BuildTool
@@ -555,7 +545,7 @@ function GetDefaultMSBuildEngine() {
function GetNuGetPackageCachePath() {
if ($env:NUGET_PACKAGES -eq $null) {
- # Use local cache on CI to ensure deterministic build.
+ # Use local cache on CI to ensure deterministic build.
# Avoid using the http cache as workaround for https://github.com/NuGet/Home/issues/3116
# use global cache in dev builds to avoid cost of downloading packages.
# For directory normalization, see also: https://github.com/NuGet/Home/issues/7968
@@ -712,7 +702,10 @@ function MSBuild-Core() {
}
foreach ($arg in $args) {
- if ($arg -ne $null -and $arg.Trim() -ne "") {
+ if ($null -ne $arg -and $arg.Trim() -ne "") {
+ if ($arg.EndsWith('\')) {
+ $arg = $arg + "\"
+ }
$cmdArgs += " `"$arg`""
}
}
@@ -784,7 +777,7 @@ function Get-Darc($version) {
. $PSScriptRoot\pipeline-logging-functions.ps1
-$RepoRoot = Resolve-Path (Join-Path $PSScriptRoot '..\..')
+$RepoRoot = Resolve-Path (Join-Path $PSScriptRoot '..\..\')
$EngRoot = Resolve-Path (Join-Path $PSScriptRoot '..')
$ArtifactsDir = Join-Path $RepoRoot 'artifacts'
$ToolsetDir = Join-Path $ArtifactsDir 'toolset'
diff --git a/eng/common/tools.sh b/eng/common/tools.sh
index 5fad184..05ca99c 100755
--- a/eng/common/tools.sh
+++ b/eng/common/tools.sh
@@ -485,13 +485,14 @@ _script_dir=`dirname "$_ResolvePath"`
eng_root=`cd -P "$_script_dir/.." && pwd`
repo_root=`cd -P "$_script_dir/../.." && pwd`
-artifacts_dir="$repo_root/artifacts"
+repo_root="${repo_root}/"
+artifacts_dir="${repo_root}artifacts"
toolset_dir="$artifacts_dir/toolset"
-tools_dir="$repo_root/.tools"
+tools_dir="${repo_root}.tools"
log_dir="$artifacts_dir/log/$configuration"
temp_dir="$artifacts_dir/tmp/$configuration"
-global_json_file="$repo_root/global.json"
+global_json_file="${repo_root}global.json"
# determine if global.json contains a "runtimes" entry
global_json_has_runtimes=false
if command -v jq &> /dev/null; then
@@ -504,7 +505,7 @@ fi
# HOME may not be defined in some scenarios, but it is required by NuGet
if [[ -z $HOME ]]; then
- export HOME="$repo_root/artifacts/.home/"
+ export HOME="${repo_root}artifacts/.home/"
mkdir -p "$HOME"
fi
diff --git a/global.json b/global.json
index 2c9110d..df8f7ea 100644
--- a/global.json
+++ b/global.json
@@ -12,13 +12,13 @@
"python3": "3.7.1"
},
"msbuild-sdks": {
- "Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk": "6.0.0-beta.21304.1",
+ "Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk": "6.0.0-beta.21311.3",
"Microsoft.DotNet.PackageValidation": "1.0.0-preview.6.21274.7",
- "Microsoft.DotNet.Arcade.Sdk": "6.0.0-beta.21304.1",
- "Microsoft.DotNet.Helix.Sdk": "6.0.0-beta.21304.1",
- "Microsoft.DotNet.SharedFramework.Sdk": "6.0.0-beta.21304.1",
+ "Microsoft.DotNet.Arcade.Sdk": "6.0.0-beta.21311.3",
+ "Microsoft.DotNet.Helix.Sdk": "6.0.0-beta.21311.3",
+ "Microsoft.DotNet.SharedFramework.Sdk": "6.0.0-beta.21311.3",
"Microsoft.Build.NoTargets": "3.0.4",
"Microsoft.Build.Traversal": "3.0.23",
- "Microsoft.NET.Sdk.IL": "6.0.0-preview.6.21307.1"
+ "Microsoft.NET.Sdk.IL": "6.0.0-preview.6.21314.1"
}
}
--
2.7.4