From 4bd66792bb0773fb1e8f5b5edb827ada47c08101 Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Mon, 29 Aug 2022 11:59:46 +0000 Subject: [PATCH] Apply clang-tidy fixes for performance-unnecessary-value-param in TestTilingInterface.cpp (NFC) --- .../TilingInterface/TestTilingInterface.cpp | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/mlir/test/lib/Interfaces/TilingInterface/TestTilingInterface.cpp b/mlir/test/lib/Interfaces/TilingInterface/TestTilingInterface.cpp index 2ba93ca..b20cd64 100644 --- a/mlir/test/lib/Interfaces/TilingInterface/TestTilingInterface.cpp +++ b/mlir/test/lib/Interfaces/TilingInterface/TestTilingInterface.cpp @@ -11,6 +11,8 @@ // //===----------------------------------------------------------------------===// +#include + #include "mlir/Dialect/Affine/IR/AffineOps.h" #include "mlir/Dialect/Func/IR/FuncOps.h" #include "mlir/Dialect/Linalg/IR/Linalg.h" @@ -40,7 +42,8 @@ struct TestTileUsingSCFForOpWithFilter : public scf::TileUsingSCFForOp { linalg::LinalgTransformationFilter filter = linalg::LinalgTransformationFilter(), PatternBenefit benefit = 1) - : scf::TileUsingSCFForOp(context, options, benefit), filter(filter) {} + : scf::TileUsingSCFForOp(context, std::move(options), benefit), + filter(std::move(filter)) {} /// Construct a generic pattern applied to `opName`. TestTileUsingSCFForOpWithFilter(StringRef opName, MLIRContext *context, @@ -48,7 +51,8 @@ struct TestTileUsingSCFForOpWithFilter : public scf::TileUsingSCFForOp { linalg::LinalgTransformationFilter filter = linalg::LinalgTransformationFilter(), PatternBenefit benefit = 1) - : scf::TileUsingSCFForOp(context, options, benefit), filter(filter) {} + : scf::TileUsingSCFForOp(context, std::move(options), benefit), + filter(std::move(filter)) {} LogicalResult matchAndRewrite(TilingInterface op, PatternRewriter &rewriter) const override { @@ -78,9 +82,9 @@ struct TestTileConsumerAndFuseProducersUsingSCFForOpWithFilter linalg::LinalgTransformationFilter filter = linalg::LinalgTransformationFilter(), PatternBenefit benefit = 1) - : scf::TileConsumerAndFuseProducersUsingSCFForOp(context, options, - benefit), - filter(filter) {} + : scf::TileConsumerAndFuseProducersUsingSCFForOp( + context, std::move(options), benefit), + filter(std::move(filter)) {} /// Construct a generic pattern applied to `opName`. TestTileConsumerAndFuseProducersUsingSCFForOpWithFilter( @@ -88,9 +92,9 @@ struct TestTileConsumerAndFuseProducersUsingSCFForOpWithFilter linalg::LinalgTransformationFilter filter = linalg::LinalgTransformationFilter(), PatternBenefit benefit = 1) - : scf::TileConsumerAndFuseProducersUsingSCFForOp(context, options, - benefit), - filter(filter) {} + : scf::TileConsumerAndFuseProducersUsingSCFForOp( + context, std::move(options), benefit), + filter(std::move(filter)) {} LogicalResult matchAndRewrite(TilingInterface op, PatternRewriter &rewriter) const override { -- 2.7.4