From 4b7622b377f4843ead2cc7012db112e0289aac6e Mon Sep 17 00:00:00 2001 From: Jan Schmidt Date: Fri, 24 Jun 2022 02:57:54 +1000 Subject: [PATCH] hlsdemux2: Fix potential segfault Fix a potential segfault if we receive a ISO-FF stream with moof before moov. Part-of: --- .../gst-plugins-good/ext/adaptivedemux2/hls/gsthlsdemux-util.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/subprojects/gst-plugins-good/ext/adaptivedemux2/hls/gsthlsdemux-util.c b/subprojects/gst-plugins-good/ext/adaptivedemux2/hls/gsthlsdemux-util.c index 0f92170..704786a 100644 --- a/subprojects/gst-plugins-good/ext/adaptivedemux2/hls/gsthlsdemux-util.c +++ b/subprojects/gst-plugins-good/ext/adaptivedemux2/hls/gsthlsdemux-util.c @@ -437,6 +437,11 @@ gst_hlsdemux_handle_content_isobmff (GstHLSDemux * demux, { GstMoofBox *moof; + if (hls_stream->moov == NULL) { + GST_WARNING ("Received moof with moov in iso-ff stream"); + break; + } + gst_byte_reader_get_sub_reader (&br, &sub, box_size - header_size); moof = gst_isoff_moof_box_parse (&sub); -- 2.7.4