From 4b7438e7dfea75d881c0412ef34c08382361625e Mon Sep 17 00:00:00 2001 From: Sergio Martins Date: Thu, 9 Jul 2015 11:17:18 +0100 Subject: [PATCH] Don't pass int by-ref in foreach Change-Id: I78753657aed14969fc35614ffba7cf480609c7de Reviewed-by: Marc Mutz --- src/assistant/help/qhelpgenerator.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/assistant/help/qhelpgenerator.cpp b/src/assistant/help/qhelpgenerator.cpp index dfb3780..7031faa 100644 --- a/src/assistant/help/qhelpgenerator.cpp +++ b/src/assistant/help/qhelpgenerator.cpp @@ -474,7 +474,7 @@ bool QHelpGenerator::insertFiles(const QStringList &files, const QString &rootPa if (filterSetId < 0) return false; ++filterSetId; - foreach (const int &attId, filterAtts) { + foreach (int attId, filterAtts) { d->query->prepare(QLatin1String("INSERT INTO FileAttributeSetTable " "VALUES(?, ?)")); d->query->bindValue(0, filterSetId); @@ -541,7 +541,7 @@ bool QHelpGenerator::insertFiles(const QStringList &files, const QString &rootPa fileId = fileMapIt.value(); QSet &fileFilterSet = d->fileFilterMap[fileId]; QSet &tmpFileFilterSet = tmpFileFilterMap[fileId]; - foreach (const int &filter, filterAtts) { + foreach (int filter, filterAtts) { if (!fileFilterSet.contains(filter) && !tmpFileFilterSet.contains(filter)) { fileFilterSet.insert(filter); -- 2.7.4