From 4b5e79cd1896de4c0f81aa1ac8b9b37d22fb428e Mon Sep 17 00:00:00 2001 From: Thiago Santos Date: Tue, 25 Aug 2015 19:37:30 -0300 Subject: [PATCH] pad: don't fallback to caps queries with proxy pads A proxy-pad should always proxy the caps related queries and events to its down or upstream peers on the other side of the element. Falling back to a caps query seems wrong. https://bugzilla.gnome.org/show_bug.cgi?id=754112 --- gst/gstpad.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/gst/gstpad.c b/gst/gstpad.c index 183fc91..86ef566 100644 --- a/gst/gstpad.c +++ b/gst/gstpad.c @@ -2973,9 +2973,8 @@ gst_pad_query_accept_caps_default (GstPad * pad, GstQuery * query) /* first forward the query to internally linked pads when we are dealing with * a PROXY CAPS */ if (GST_PAD_IS_PROXY_CAPS (pad)) { - if ((result = gst_pad_proxy_query_accept_caps (pad, query))) { - goto done; - } + result = gst_pad_proxy_query_accept_caps (pad, query); + goto done; } GST_CAT_DEBUG_OBJECT (GST_CAT_PERFORMANCE, pad, -- 2.7.4