From 4ad48513fc28e5182785d18dc8dac898a98fe918 Mon Sep 17 00:00:00 2001 From: DoHyun Pyun Date: Mon, 18 Nov 2019 09:41:18 +0900 Subject: [PATCH] Fix coverity issues - Resource leaks Change-Id: I62bdabd1cf208c3f7291f94eddc029d332235f42 Signed-off-by: DoHyun Pyun --- bt-api/bt-event-handler.c | 1 + bt-oal/bluez_hal/src/bt-hal-adapter-le.c | 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/bt-api/bt-event-handler.c b/bt-api/bt-event-handler.c index afe92d5..913563e 100644 --- a/bt-api/bt-event-handler.c +++ b/bt-api/bt-event-handler.c @@ -506,6 +506,7 @@ void __bt_adapter_event_filter(GDBusConnection *connection, event_info->cb, event_info->user_data); g_slist_free(data->atm_list); g_free(data); + g_array_free(dbus_data, TRUE); } else if (strcasecmp(signal_name, BT_DISCOVERABLE_MODE_CHANGED) == 0) { int mode = 0; diff --git a/bt-oal/bluez_hal/src/bt-hal-adapter-le.c b/bt-oal/bluez_hal/src/bt-hal-adapter-le.c index 27b56fb..5f561d9 100644 --- a/bt-oal/bluez_hal/src/bt-hal-adapter-le.c +++ b/bt-oal/bluez_hal/src/bt-hal-adapter-le.c @@ -1020,10 +1020,11 @@ int _bt_hal_adapter_le_set_manufacturer_data(bt_manufacturer_data_t *m_data) if (proxy == NULL) return BT_STATUS_FAIL; - builder = g_variant_builder_new(G_VARIANT_TYPE("ay")); - if (m_data->data_len + 2 >= BT_MANUFACTURER_DATA_LENGTH_MAX) return BT_STATUS_PARM_INVALID; + + builder = g_variant_builder_new(G_VARIANT_TYPE("ay")); + for (i = 0; i < (m_data->data_len) + 2; i++) g_variant_builder_add(builder, "y", m_data->data[i]); -- 2.7.4