From 4a91a93d4e651210e7d56dc188184d2ea08d2645 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Sebastian=20Dr=C3=B6ge?= Date: Wed, 25 Sep 2013 12:55:21 +0200 Subject: [PATCH] qtmux: Don't error out if downstream is not seekable for non-fragmented variants Doing so would be a regression over 1.0 and breaks the unit test. However the result will be most likely unusable, so let's post a warning message on the bus. --- gst/isomp4/gstqtmux.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/gst/isomp4/gstqtmux.c b/gst/isomp4/gstqtmux.c index 58533a4..3231963 100644 --- a/gst/isomp4/gstqtmux.c +++ b/gst/isomp4/gstqtmux.c @@ -1653,7 +1653,11 @@ gst_qt_mux_start_file (GstQTMux * qtmux) if (!seekable) { if (qtmux_klass->format != GST_QT_MUX_FORMAT_ISML) { if (!qtmux->fast_start) { - goto not_seekable_error; + GST_ELEMENT_WARNING (qtmux, STREAM, FAILED, + ("Downstream is not seekable and headers can't be rewritten"), + (NULL)); + /* FIXME: Is there something better we can do? */ + qtmux->streamable = TRUE; } } else { GST_WARNING_OBJECT (qtmux, "downstream is not seekable, but " @@ -1774,15 +1778,6 @@ gst_qt_mux_start_file (GstQTMux * qtmux) exit: return ret; -not_seekable_error: - { - GST_ELEMENT_ERROR (qtmux, STREAM, FAILED, - ("Downstream is not seekable and headers can't be rewritten"), - GST_ERROR_SYSTEM); - GST_OBJECT_UNLOCK (qtmux); - return GST_FLOW_ERROR; - } - /* ERRORS */ open_failed: { -- 2.7.4